Stupid lockdep question...

Stupid lockdep question...

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

I have a 3rd-party module, that throws this whinge:

[   65.831296] INFO: trying to register non-static key.
[   65.831301] the code is fine but needs lockdep annotation.
[   65.831303] turning off the locking correctness validator.

I've identified that it's a call to down(*foo) where foo points to a kmalloc'ed
block of memory that's memset() to all-zeros. What's the initializer/annotation
I need to add to my code?


[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]

Re: Stupid lockdep question...

[Arnd Bergmann]

On Wednesday 13 October 2010, Valdis.Kletnieks@vt.edu wrote:
>   I have a 3rd-party module, that throws this whinge:
> 
> [   65.831296] INFO: trying to register non-static key.
> [   65.831301] the code is fine but needs lockdep annotation.
> [   65.831303] turning off the locking correctness validator.
> 
> I've identified that it's a call to down(*foo) where foo points to a kmalloc'ed
> block of memory that's memset() to all-zeros. What's the initializer/annotation
> I need to add to my code?
> 

It would be easier if you posted a link to the source, but the best
answer is problably:

- replace the semaphore with a regular mutex,
- use mutex_init to initialize it after the allocation.

	Arnd