From: Mat Martineau <mathew.j.martineau at linux.intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [MPTCP][PATCH mptcp-next] mptcp: use MPTCPOPT_HMAC_LEN macro
Date: Thu, 03 Dec 2020 17:59:07 -0800 [thread overview]
Message-ID: <388dbbbe-bca8-9ef8-b33a-3737653e8dfb@linux.intel.com> (raw)
In-Reply-To: 1ab161c24f9027ce76b3483f025be8bbfa0c7667.1606899179.git.geliangtang@gmail.com
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Wed, 2 Dec 2020, Geliang Tang wrote:
> Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct
> mptcp_options_received.
>
> Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
> ---
> net/mptcp/protocol.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> index 6933cdc2e605..4e922620ee56 100644
> --- a/net/mptcp/protocol.h
> +++ b/net/mptcp/protocol.h
> @@ -122,7 +122,7 @@ struct mptcp_options_received {
> u32 token;
> u32 nonce;
> u64 thmac;
> - u8 hmac[20];
> + u8 hmac[MPTCPOPT_HMAC_LEN];
> u8 join_id;
> u8 use_map:1,
> dsn64:1,
> --
> 2.26.2
Looks good to me.
Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
--
Mat Martineau
Intel
next reply other threads:[~2020-12-04 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 1:59 Mat Martineau [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-04 17:09 [MPTCP] Re: [MPTCP][PATCH mptcp-next] mptcp: use MPTCPOPT_HMAC_LEN macro Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=388dbbbe-bca8-9ef8-b33a-3737653e8dfb@linux.intel.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.