* [MPTCP] Re: [MPTCP][PATCH mptcp-next] mptcp: use MPTCPOPT_HMAC_LEN macro
@ 2020-12-04 1:59 Mat Martineau
0 siblings, 0 replies; 2+ messages in thread
From: Mat Martineau @ 2020-12-04 1:59 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Wed, 2 Dec 2020, Geliang Tang wrote:
> Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct
> mptcp_options_received.
>
> Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
> ---
> net/mptcp/protocol.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> index 6933cdc2e605..4e922620ee56 100644
> --- a/net/mptcp/protocol.h
> +++ b/net/mptcp/protocol.h
> @@ -122,7 +122,7 @@ struct mptcp_options_received {
> u32 token;
> u32 nonce;
> u64 thmac;
> - u8 hmac[20];
> + u8 hmac[MPTCPOPT_HMAC_LEN];
> u8 join_id;
> u8 use_map:1,
> dsn64:1,
> --
> 2.26.2
Looks good to me.
Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [MPTCP] Re: [MPTCP][PATCH mptcp-next] mptcp: use MPTCPOPT_HMAC_LEN macro
@ 2020-12-04 17:09 Matthieu Baerts
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Baerts @ 2020-12-04 17:09 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Hi Geliang, Mat,
On 02/12/2020 09:54, Geliang Tang wrote:
> Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct
> mptcp_options_received.
>
> Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
Thank you for the patch and the review!
This patch has been applied after other patches from Geliang.
- 0ebaa63b1d30: mptcp: use MPTCPOPT_HMAC_LEN macro
- With Mat's tag
- Results: 95b2727396d3..8e81e32d0db6
Tests + export are going to be started soon!
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-04 17:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-04 1:59 [MPTCP] Re: [MPTCP][PATCH mptcp-next] mptcp: use MPTCPOPT_HMAC_LEN macro Mat Martineau
-- strict thread matches above, loose matches on Subject: below --
2020-12-04 17:09 Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.