All of lore.kernel.org
 help / color / mirror / Atom feed
From: abhinavk@codeaurora.org
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	freedreno <freedreno@lists.freedesktop.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd'
Date: Wed, 07 Apr 2021 10:51:54 -0700	[thread overview]
Message-ID: <38969a7640a5067a714fc87fb5aa7d3a@codeaurora.org> (raw)
In-Reply-To: <20210407082315.2703-1-thunder.leizhen@huawei.com>

On 2021-04-07 01:23, Zhen Lei wrote:
> Fixes the following W=1 kernel build warning:
> 
> drivers/gpu/drm/msm/dp/dp_display.c: In function
> ‘dp_display_usbpd_attention_cb’:
> drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’
> set but not used [-Wunused-but-set-variable]
> 
> Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at 
> irq_hpd")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 5a39da6e1eaf277..31bf2a40a9eb2c9 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct 
> device *dev)
>  	int rc = 0;
>  	u32 sink_request;
>  	struct dp_display_private *dp;
> -	struct dp_usbpd *hpd;
> 
>  	if (!dev) {
>  		DRM_ERROR("invalid dev\n");
> @@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct 
> device *dev)
>  		return -ENODEV;
>  	}
> 
> -	hpd = dp->usbpd;
> -
>  	/* check for any test request issued by sink */
>  	rc = dp_link_process_request(dp->link);
>  	if (!rc) {

WARNING: multiple messages have this Message-ID (diff)
From: abhinavk@codeaurora.org
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: freedreno <freedreno@lists.freedesktop.org>,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd'
Date: Wed, 07 Apr 2021 10:51:54 -0700	[thread overview]
Message-ID: <38969a7640a5067a714fc87fb5aa7d3a@codeaurora.org> (raw)
In-Reply-To: <20210407082315.2703-1-thunder.leizhen@huawei.com>

On 2021-04-07 01:23, Zhen Lei wrote:
> Fixes the following W=1 kernel build warning:
> 
> drivers/gpu/drm/msm/dp/dp_display.c: In function
> ‘dp_display_usbpd_attention_cb’:
> drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’
> set but not used [-Wunused-but-set-variable]
> 
> Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at 
> irq_hpd")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 5a39da6e1eaf277..31bf2a40a9eb2c9 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct 
> device *dev)
>  	int rc = 0;
>  	u32 sink_request;
>  	struct dp_display_private *dp;
> -	struct dp_usbpd *hpd;
> 
>  	if (!dev) {
>  		DRM_ERROR("invalid dev\n");
> @@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct 
> device *dev)
>  		return -ENODEV;
>  	}
> 
> -	hpd = dp->usbpd;
> -
>  	/* check for any test request issued by sink */
>  	rc = dp_link_process_request(dp->link);
>  	if (!rc) {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-04-07 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  8:23 [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd' Zhen Lei
2021-04-07  8:23 ` Zhen Lei
2021-04-07 17:51 ` abhinavk [this message]
2021-04-07 17:51   ` abhinavk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38969a7640a5067a714fc87fb5aa7d3a@codeaurora.org \
    --to=abhinavk@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.