Re: [PATCH 1/2 v3] ARM: s3c24xx: get rid of custom <mach/gpio.h>

["Heiko Stübner" <heiko@sntech.de>]

Am Dienstag, 7. Januar 2014, 19:27:49 schrieb Linus Walleij:
> On Tue, Jan 7, 2014 at 12:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Friday 13 December 2013, Linus Walleij wrote:
> > * The file includes <plat/gpio-cfg.h>, which is not a bug yet, but
> > 
> >   will be once we move s3c24xx to multiplatform, which would make
> >   it impossible to include this file from outside of arch/arm.
> 
> Yes that needs to be a step for multiplatform enablement.
> My series only tries to make the problem smaller and remove
> the dependence on <mach/gpio.h>. All the <mach/*> and
> <plat/*> stuff needs to go away eventually ...
>
> > Note that on Exynos, the solution for the gpio driver dependencies
> > was to scrap the driver and use pinctrl-exynos instead.
> 
> I think the S3C driver is a different piece of hardware unfortunately.

both the s3c24xx as well as the exynos pinctrl driver use the common pinctrl-
samsung infrastructure. The biggest part of the pinctrl-{exynos,s3c24xx} 
drivers is the handling of the gpio-interrupts and defining the available 
banks.

In general my multiplatform-plan is to provide the basics (pinctrl, common-
clock, etc) and then take the easy way out, described in some arm-summit-notes 
by simply removing the boards and let people with the hardware that care about 
it readd the specifics :-) .

For example it seems nobody started a S3C2442 machine for quite some time, as 
it was/is missing the clkdev entries for stuff like the serial ports.


Heiko