From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Kumar Gala <galak@kernel.crashing.org>,
Pete Zaitcev <zaitcev@redhat.com>, Greg KH <greg@kroah.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout()
Date: Thu, 27 Sep 2007 09:50:16 +0800 [thread overview]
Message-ID: <390857819.00313@ustc.edu.cn> (raw)
Message-ID: <20070927015016.GA11080@mail.ustc.edu.cn> (raw)
We don't want to introduce pointless delays in throttle_vm_writeout()
when the writeback limits are not yet exceeded, do we?
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Kumar Gala <galak@kernel.crashing.org>
Cc: Pete Zaitcev <zaitcev@redhat.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
mm/page-writeback.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
--- linux-2.6.23-rc8-mm1.orig/mm/page-writeback.c
+++ linux-2.6.23-rc8-mm1/mm/page-writeback.c
@@ -507,16 +507,6 @@ void throttle_vm_writeout(gfp_t gfp_mask
long background_thresh;
long dirty_thresh;
- if ((gfp_mask & (__GFP_FS|__GFP_IO)) != (__GFP_FS|__GFP_IO)) {
- /*
- * The caller might hold locks which can prevent IO completion
- * or progress in the filesystem. So we cannot just sit here
- * waiting for IO to complete.
- */
- congestion_wait(WRITE, HZ/10);
- return;
- }
-
for ( ; ; ) {
get_dirty_limits(&background_thresh, &dirty_thresh, NULL, NULL);
@@ -530,6 +520,14 @@ void throttle_vm_writeout(gfp_t gfp_mask
global_page_state(NR_WRITEBACK) <= dirty_thresh)
break;
congestion_wait(WRITE, HZ/10);
+
+ /*
+ * The caller might hold locks which can prevent IO completion
+ * or progress in the filesystem. So we cannot just sit here
+ * waiting for IO to complete.
+ */
+ if ((gfp_mask & (__GFP_FS|__GFP_IO)) != (__GFP_FS|__GFP_IO))
+ break;
}
}
next reply other threads:[~2007-09-27 1:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 1:50 Fengguang Wu [this message]
2007-09-27 1:50 ` [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout() Fengguang Wu
2007-09-27 15:16 ` Rik van Riel
2007-09-28 1:18 ` Fengguang Wu
2007-09-28 1:18 ` Fengguang Wu
2007-09-27 20:47 ` Andrew Morton
2007-09-28 8:02 ` Ingo Molnar
2007-09-27 22:59 ` Nick Piggin
2007-09-28 16:23 ` Mathieu Desnoyers
2007-09-28 0:10 ` Nick Piggin
2007-09-28 17:57 ` Mathieu Desnoyers
2007-09-28 19:50 ` Frank Ch. Eigler
2007-09-28 20:25 ` Nick Piggin
2007-09-27 21:49 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=390857819.00313@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=galak@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.