All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Vinod Koul <vkoul@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Felipe Balbi <balbi@ti.com>,
	Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-phy@lists.infradead.org,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v18 3/5] phy: core: Add devm_phy_get_by_of_node()
Date: Thu, 17 Sep 2026 16:03:17 +0100	[thread overview]
Message-ID: <390980e3-a76c-404e-8adf-7848b31348dc@kernel.org> (raw)
In-Reply-To: <37f182ad-a137-4066-9e94-b06be2cd03da@linaro.org>

On 17/09/2026 14:27, Bryan O'Donoghue wrote:
> On 17/09/2026 13:32, Neil Armstrong wrote:
>>> -        dev_dbg(dev, "failed to create device link to %s\n",
>>> +        dev_err(dev, "failed to create device link to %s\n",
>>>                dev_name(phy->dev.parent));
>>
>> This change belongs in another patch.
> 
> Doh Frank gave me a comment on this and I just changed it without
> realising this isn't in my series at all.
> 
> I'll drop this altogether
> 
> ---
> bod

Hmm now I see, there's another device_link_add which does a dev_dbg() on 
failure, the feedback was to dev_err() with the part I'm adding below...

+	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
+	if (!link)
+		dev_dbg(dev, "failed to create device link to %s\n",
+			dev_name(phy->dev.parent));
+

device_link_add() will return NULL when the supplier the PHY is a child 
of the consumer so !link is not an error.

---
bod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Bryan O'Donoghue <bod@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Vinod Koul <vkoul@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Felipe Balbi <balbi@ti.com>,
	Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-phy@lists.infradead.org,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v18 3/5] phy: core: Add devm_phy_get_by_of_node()
Date: Thu, 17 Sep 2026 16:03:17 +0100	[thread overview]
Message-ID: <390980e3-a76c-404e-8adf-7848b31348dc@kernel.org> (raw)
In-Reply-To: <37f182ad-a137-4066-9e94-b06be2cd03da@linaro.org>

On 17/09/2026 14:27, Bryan O'Donoghue wrote:
> On 17/09/2026 13:32, Neil Armstrong wrote:
>>> -        dev_dbg(dev, "failed to create device link to %s\n",
>>> +        dev_err(dev, "failed to create device link to %s\n",
>>>                dev_name(phy->dev.parent));
>>
>> This change belongs in another patch.
> 
> Doh Frank gave me a comment on this and I just changed it without
> realising this isn't in my series at all.
> 
> I'll drop this altogether
> 
> ---
> bod

Hmm now I see, there's another device_link_add which does a dev_dbg() on 
failure, the feedback was to dev_err() with the part I'm adding below...

+	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
+	if (!link)
+		dev_dbg(dev, "failed to create device link to %s\n",
+			dev_name(phy->dev.parent));
+

device_link_add() will return NULL when the supplier the PHY is a child 
of the consumer so !link is not an error.

---
bod



  reply	other threads:[~2026-09-17 15:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 11:07 [PATCH v18 0/5] Add phy_get_by_of_node and devm helper Bryan O'Donoghue
2026-09-17 11:07 ` Bryan O'Donoghue
2026-09-17 11:07 ` [PATCH v18 1/5] phy: core: Fix race-condition between _of_phy_get() and try_module_get() Bryan O'Donoghue
2026-09-17 11:07   ` Bryan O'Donoghue
2026-09-17 11:07 ` [PATCH v18 2/5] phy: core: Add phy_get_by_of_node() Bryan O'Donoghue
2026-09-17 11:07   ` Bryan O'Donoghue
2026-09-17 11:18   ` sashiko-bot
2026-09-17 11:18     ` sashiko-bot
2026-09-17 12:29   ` Neil Armstrong
2026-09-17 12:29     ` Neil Armstrong
2026-09-17 12:32     ` Bryan O'Donoghue
2026-09-17 12:32       ` Bryan O'Donoghue
2026-09-17 11:07 ` [PATCH v18 3/5] phy: core: Add devm_phy_get_by_of_node() Bryan O'Donoghue
2026-09-17 11:07   ` Bryan O'Donoghue
2026-09-17 11:18   ` sashiko-bot
2026-09-17 11:18     ` sashiko-bot
2026-09-17 12:32   ` Neil Armstrong
2026-09-17 12:32     ` Neil Armstrong
2026-09-17 12:43     ` Bryan O'Donoghue
2026-09-17 12:43       ` Bryan O'Donoghue
2026-09-17 13:27     ` Bryan O'Donoghue
2026-09-17 13:27       ` Bryan O'Donoghue
2026-09-17 15:03       ` Bryan O'Donoghue [this message]
2026-09-17 15:03         ` Bryan O'Donoghue
2026-09-17 11:07 ` [PATCH v18 4/5] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-09-17 11:07   ` Bryan O'Donoghue
2026-09-17 11:19   ` sashiko-bot
2026-09-17 11:19     ` sashiko-bot
2026-09-17 11:07 ` [PATCH v18 5/5] media: qcom: camss: Use data-lanes starting at 1 for new CSIPHY mode Bryan O'Donoghue
2026-09-17 11:07   ` Bryan O'Donoghue
2026-09-17 13:05   ` Loic Poulain
2026-09-17 13:05     ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=390980e3-a76c-404e-8adf-7848b31348dc@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=balbi@ti.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mani@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.