From: Tomasz Figa <t.figa@samsung.com>
To: Olof Johansson <olof@lixom.net>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com,
kgene.kim@samsung.com, linux@arm.linux.org.uk, arnd@arndb.de
Subject: Re: [PATCH 4/5] ARM: EXYNOS: Add support for Exynos secure firmware
Date: Wed, 19 Sep 2012 12:10:35 +0200 [thread overview]
Message-ID: <3910462.8Opr7bJoeX@amdc1227> (raw)
In-Reply-To: <20120916004455.GD7028@quad.lixom.net>
Hi Olof,
On Saturday 15 of September 2012 17:44:55 Olof Johansson wrote:
> On Thu, Sep 13, 2012 at 10:13:37AM +0200, Tomasz Figa wrote:
> > +static void __iomem *exynos_cpu_boot_reg(int cpu)
> > +{
> > + return S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
> > +}
>
> This communication area in sysram should probably be seen as a part of
> the firmware interface. It should thus be defined as part of the binding
> instead, i.e. through a reg property or similar there. That also would
> make it easy to convert to using ioremap() instead of iodesc tables,
> which always a nice thing.
The problem with SYSRAM_NS is that it might be also used in other code, not
related to firmware only. I don't know exactly all the use cases for it.
Is it really a big problem or we could let it be for now, merge the patches
for firmware and then convert SYSRAM_NS to dynamic mapping when its
situation clarifies?
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: EXYNOS: Add support for Exynos secure firmware
Date: Wed, 19 Sep 2012 12:10:35 +0200 [thread overview]
Message-ID: <3910462.8Opr7bJoeX@amdc1227> (raw)
In-Reply-To: <20120916004455.GD7028@quad.lixom.net>
Hi Olof,
On Saturday 15 of September 2012 17:44:55 Olof Johansson wrote:
> On Thu, Sep 13, 2012 at 10:13:37AM +0200, Tomasz Figa wrote:
> > +static void __iomem *exynos_cpu_boot_reg(int cpu)
> > +{
> > + return S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
> > +}
>
> This communication area in sysram should probably be seen as a part of
> the firmware interface. It should thus be defined as part of the binding
> instead, i.e. through a reg property or similar there. That also would
> make it easy to convert to using ioremap() instead of iodesc tables,
> which always a nice thing.
The problem with SYSRAM_NS is that it might be also used in other code, not
related to firmware only. I don't know exactly all the use cases for it.
Is it really a big problem or we could let it be for now, merge the patches
for firmware and then convert SYSRAM_NS to dynamic mapping when its
situation clarifies?
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
next prev parent reply other threads:[~2012-09-19 10:10 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 8:13 [PATCH 0/5] ARM: EXYNOS: Add secure firmware support Tomasz Figa
2012-09-13 8:13 ` Tomasz Figa
2012-09-13 8:13 ` [PATCH 1/5] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM Tomasz Figa
2012-09-13 8:13 ` Tomasz Figa
2012-09-13 8:13 ` [PATCH 2/5] ARM: Add interface for registering and calling firmware-specific operations Tomasz Figa
2012-09-13 8:13 ` Tomasz Figa
2012-09-13 8:25 ` Tomasz Figa
2012-09-13 8:25 ` Tomasz Figa
2012-09-22 5:50 ` Olof Johansson
2012-09-22 5:50 ` Olof Johansson
2012-09-22 6:01 ` Kyungmin Park
2012-09-22 6:01 ` Kyungmin Park
2012-09-22 6:23 ` Olof Johansson
2012-09-22 6:23 ` Olof Johansson
2012-09-22 13:17 ` Tomasz Figa
2012-09-22 13:17 ` Tomasz Figa
2012-09-22 13:22 ` Russell King - ARM Linux
2012-09-22 13:22 ` Russell King - ARM Linux
2012-09-13 8:13 ` [PATCH 3/5] ARM: EXYNOS: Add support for secure monitor calls Tomasz Figa
2012-09-13 8:13 ` Tomasz Figa
2012-09-13 8:13 ` [PATCH 4/5] ARM: EXYNOS: Add support for Exynos secure firmware Tomasz Figa
2012-09-13 8:13 ` Tomasz Figa
2012-09-16 0:44 ` Olof Johansson
2012-09-16 0:44 ` Olof Johansson
2012-09-19 10:10 ` Tomasz Figa [this message]
2012-09-19 10:10 ` Tomasz Figa
2012-09-22 5:39 ` Olof Johansson
2012-09-22 5:39 ` Olof Johansson
2012-09-22 5:57 ` Kyungmin Park
2012-09-22 5:57 ` Kyungmin Park
2012-09-22 6:36 ` Olof Johansson
2012-09-22 6:36 ` Olof Johansson
2012-09-22 6:39 ` Kyungmin Park
2012-09-22 6:39 ` Kyungmin Park
2012-09-24 14:39 ` Tomasz Figa
2012-09-24 14:39 ` Tomasz Figa
2012-09-13 8:13 ` [PATCH 5/5] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up Tomasz Figa
2012-09-13 8:13 ` Tomasz Figa
2012-09-19 13:29 ` [PATCH 0/5] ARM: EXYNOS: Add secure firmware support Tomasz Figa
2012-09-19 13:29 ` Tomasz Figa
2012-09-21 8:39 ` Kyungmin Park
2012-09-21 8:39 ` Kyungmin Park
2012-09-22 5:52 ` Olof Johansson
2012-09-22 5:52 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3910462.8Opr7bJoeX@amdc1227 \
--to=t.figa@samsung.com \
--cc=arnd@arndb.de \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.