From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, Dragan Simic <dsimic@manjaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better
Date: Wed, 21 Aug 2024 10:41:07 +0200 [thread overview]
Message-ID: <39189616.J2Yia2DhmK@diego> (raw)
In-Reply-To: <96200baf794a0c451f3bbc3f5530b8cf0e359dfc.1724225528.git.dsimic@manjaro.org>
Am Mittwoch, 21. August 2024, 09:37:54 CEST schrieb Dragan Simic:
> Return the actual error code upon failure to allocate extcon device, instead
> of hardcoding -ENOMEM. Use dev_err_probe() to also log appropriate messages,
> which is fine because the containing function is used in the probe path.
>
> Helped-by: Heiko Stubner <heiko@sntech.de>
How did I help with this? :-D
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, Dragan Simic <dsimic@manjaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better
Date: Wed, 21 Aug 2024 10:41:07 +0200 [thread overview]
Message-ID: <39189616.J2Yia2DhmK@diego> (raw)
In-Reply-To: <96200baf794a0c451f3bbc3f5530b8cf0e359dfc.1724225528.git.dsimic@manjaro.org>
Am Mittwoch, 21. August 2024, 09:37:54 CEST schrieb Dragan Simic:
> Return the actual error code upon failure to allocate extcon device, instead
> of hardcoding -ENOMEM. Use dev_err_probe() to also log appropriate messages,
> which is fine because the containing function is used in the probe path.
>
> Helped-by: Heiko Stubner <heiko@sntech.de>
How did I help with this? :-D
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, Dragan Simic <dsimic@manjaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better
Date: Wed, 21 Aug 2024 10:41:07 +0200 [thread overview]
Message-ID: <39189616.J2Yia2DhmK@diego> (raw)
In-Reply-To: <96200baf794a0c451f3bbc3f5530b8cf0e359dfc.1724225528.git.dsimic@manjaro.org>
Am Mittwoch, 21. August 2024, 09:37:54 CEST schrieb Dragan Simic:
> Return the actual error code upon failure to allocate extcon device, instead
> of hardcoding -ENOMEM. Use dev_err_probe() to also log appropriate messages,
> which is fine because the containing function is used in the probe path.
>
> Helped-by: Heiko Stubner <heiko@sntech.de>
How did I help with this? :-D
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2024-08-21 8:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 7:37 [PATCH v2 0/3] Improve error handling in Rockchip Inno USB 2.0 PHY driver Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 7:37 ` [PATCH v2 1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 8:39 ` Heiko Stübner
2024-08-21 8:39 ` Heiko Stübner
2024-08-21 8:39 ` Heiko Stübner
2024-08-21 8:53 ` Dragan Simic
2024-08-21 8:53 ` Dragan Simic
2024-08-21 8:53 ` Dragan Simic
2024-08-21 7:37 ` [PATCH v2 2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 8:41 ` Heiko Stübner [this message]
2024-08-21 8:41 ` Heiko Stübner
2024-08-21 8:41 ` Heiko Stübner
2024-08-21 8:55 ` Dragan Simic
2024-08-21 8:55 ` Dragan Simic
2024-08-21 8:55 ` Dragan Simic
2024-08-21 11:17 ` Christophe JAILLET
2024-08-21 11:17 ` Christophe JAILLET
2024-08-21 11:17 ` Christophe JAILLET
2024-08-21 19:05 ` Dragan Simic
2024-08-21 19:05 ` Dragan Simic
2024-08-21 19:05 ` Dragan Simic
2024-08-21 7:37 ` [PATCH v2 3/3] phy: phy-rockchip-inno-usb2: Improve error handling while probing Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 7:37 ` Dragan Simic
2024-08-21 8:44 ` Heiko Stübner
2024-08-21 8:44 ` Heiko Stübner
2024-08-21 8:44 ` Heiko Stübner
2024-08-21 9:09 ` Dragan Simic
2024-08-21 9:09 ` Dragan Simic
2024-08-21 9:09 ` Dragan Simic
2024-08-21 9:17 ` Heiko Stübner
2024-08-21 9:17 ` Heiko Stübner
2024-08-21 9:17 ` Heiko Stübner
2024-08-21 9:34 ` Dragan Simic
2024-08-21 9:34 ` Dragan Simic
2024-08-21 9:34 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39189616.J2Yia2DhmK@diego \
--to=heiko@sntech.de \
--cc=dsimic@manjaro.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.