All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timothy Pearson <tpearson@raptorengineering.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Shivaprasad G Bhat <sbhat@linux.ibm.com>,
	iommu@lists.linux.dev,
	 linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 Michael Ellerman <mpe@ellerman.id.au>,
	npiggin <npiggin@gmail.com>,
	 christophe leroy <christophe.leroy@csgroup.eu>,
	 aneesh kumar <aneesh.kumar@kernel.org>,
	 naveen n rao <naveen.n.rao@linux.ibm.com>,
	jroedel@suse.de,
	 Timothy Pearson <tpearson@raptorengineering.com>,
	aik@amd.com,  bgray@linux.ibm.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 gbatra@linux.vnet.ibm.com, vaibhav@linux.ibm.com
Subject: Re: [PATCH 1/2] powerpc: iommu: Bring back table group release_ownership() call
Date: Fri, 26 Jan 2024 09:29:55 -0600 (CST)	[thread overview]
Message-ID: <392247278.10124607.1706282995795.JavaMail.zimbra@raptorengineeringinc.com> (raw)
In-Reply-To: <20240126151701.GZ50608@ziepe.ca>



----- Original Message -----
> From: "Jason Gunthorpe" <jgg@ziepe.ca>
> To: "Shivaprasad G Bhat" <sbhat@linux.ibm.com>
> Cc: iommu@lists.linux.dev, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "Michael Ellerman" <mpe@ellerman.id.au>, "npiggin" <npiggin@gmail.com>, "christophe
> leroy" <christophe.leroy@csgroup.eu>, "aneesh kumar" <aneesh.kumar@kernel.org>, "naveen n rao"
> <naveen.n.rao@linux.ibm.com>, jroedel@suse.de, "Timothy Pearson" <tpearson@raptorengineering.com>, aik@amd.com,
> bgray@linux.ibm.com, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, gbatra@linux.vnet.ibm.com,
> vaibhav@linux.ibm.com
> Sent: Friday, January 26, 2024 9:17:01 AM
> Subject: Re: [PATCH 1/2] powerpc: iommu: Bring back table group release_ownership() call

> On Fri, Jan 26, 2024 at 08:43:12PM +0530, Shivaprasad G Bhat wrote:
>> > Also, is there any chance someone can work on actually fixing this to
>> > be a proper iommu driver? I think that will become important for power
>> > to use the common dma_iommu code in the next year...
>> We are looking into it.
> 
> Okay, let me know, I can possibly help make parts of this happen
> 
> power is the last still-current architecture to be outside the modern
> IOMMU and DMA API design and I'm going to start proposing things that
> will not be efficient on power because of this.

I can get development resources on this fairly rapidly, including testing.  We should figure out the best way forward and how to deal with the VFIO side of things, even if that's a rewrite at the end of the day the machine-specific codebase isn't *that* large for our two target flavors (64-bit PowerNV and 64-bit pSeries).

> I think a basic iommu driver using the dma API would not be so hard.
> 
> I don't know what to do about the SPAPR VFIO mess though. :(
> 
> Jason

WARNING: multiple messages have this Message-ID (diff)
From: Timothy Pearson <tpearson@raptorengineering.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: jroedel@suse.de, gbatra@linux.vnet.ibm.com,
	Shivaprasad G Bhat <sbhat@linux.ibm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	npiggin <npiggin@gmail.com>,
	aneesh kumar <aneesh.kumar@kernel.org>,
	Timothy Pearson <tpearson@raptorengineering.com>,
	iommu@lists.linux.dev, bgray@linux.ibm.com,
	naveen n rao <naveen.n.rao@linux.ibm.com>,
	vaibhav@linux.ibm.com,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	aik@amd.com
Subject: Re: [PATCH 1/2] powerpc: iommu: Bring back table group release_ownership() call
Date: Fri, 26 Jan 2024 09:29:55 -0600 (CST)	[thread overview]
Message-ID: <392247278.10124607.1706282995795.JavaMail.zimbra@raptorengineeringinc.com> (raw)
In-Reply-To: <20240126151701.GZ50608@ziepe.ca>



----- Original Message -----
> From: "Jason Gunthorpe" <jgg@ziepe.ca>
> To: "Shivaprasad G Bhat" <sbhat@linux.ibm.com>
> Cc: iommu@lists.linux.dev, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "Michael Ellerman" <mpe@ellerman.id.au>, "npiggin" <npiggin@gmail.com>, "christophe
> leroy" <christophe.leroy@csgroup.eu>, "aneesh kumar" <aneesh.kumar@kernel.org>, "naveen n rao"
> <naveen.n.rao@linux.ibm.com>, jroedel@suse.de, "Timothy Pearson" <tpearson@raptorengineering.com>, aik@amd.com,
> bgray@linux.ibm.com, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, gbatra@linux.vnet.ibm.com,
> vaibhav@linux.ibm.com
> Sent: Friday, January 26, 2024 9:17:01 AM
> Subject: Re: [PATCH 1/2] powerpc: iommu: Bring back table group release_ownership() call

> On Fri, Jan 26, 2024 at 08:43:12PM +0530, Shivaprasad G Bhat wrote:
>> > Also, is there any chance someone can work on actually fixing this to
>> > be a proper iommu driver? I think that will become important for power
>> > to use the common dma_iommu code in the next year...
>> We are looking into it.
> 
> Okay, let me know, I can possibly help make parts of this happen
> 
> power is the last still-current architecture to be outside the modern
> IOMMU and DMA API design and I'm going to start proposing things that
> will not be efficient on power because of this.

I can get development resources on this fairly rapidly, including testing.  We should figure out the best way forward and how to deal with the VFIO side of things, even if that's a rewrite at the end of the day the machine-specific codebase isn't *that* large for our two target flavors (64-bit PowerNV and 64-bit pSeries).

> I think a basic iommu driver using the dma API would not be so hard.
> 
> I don't know what to do about the SPAPR VFIO mess though. :(
> 
> Jason

  reply	other threads:[~2024-01-26 15:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 12:08 [PATCH 0/2] powerpc: iommu: Fix the vfio-pci bind and unbind issues Shivaprasad G Bhat
2024-01-25 12:08 ` Shivaprasad G Bhat
2024-01-25 12:08 ` [PATCH 1/2] powerpc: iommu: Bring back table group release_ownership() call Shivaprasad G Bhat
2024-01-25 12:08   ` Shivaprasad G Bhat
2024-01-25 15:50   ` Jason Gunthorpe
2024-01-25 15:50     ` Jason Gunthorpe
2024-01-26 15:13     ` Shivaprasad G Bhat
2024-01-26 15:13       ` Shivaprasad G Bhat
2024-01-26 15:17       ` Jason Gunthorpe
2024-01-26 15:17         ` Jason Gunthorpe
2024-01-26 15:29         ` Timothy Pearson [this message]
2024-01-26 15:29           ` Timothy Pearson
2024-01-26 15:38           ` Jason Gunthorpe
2024-01-26 15:38             ` Jason Gunthorpe
2024-01-26 15:39             ` Timothy Pearson
2024-01-26 15:39               ` Timothy Pearson
2024-01-26 15:44               ` Timothy Pearson
2024-01-26 15:44                 ` Timothy Pearson
2024-01-26 15:44               ` Jason Gunthorpe
2024-01-26 15:44                 ` Jason Gunthorpe
2024-01-25 12:08 ` [PATCH 2/2] iommu: Fix the domain type checks when default_domain is set Shivaprasad G Bhat
2024-01-25 12:08   ` Shivaprasad G Bhat
2024-01-25 15:52   ` Jason Gunthorpe
2024-01-25 15:52     ` Jason Gunthorpe
2024-01-26 15:19     ` Shivaprasad G Bhat
2024-01-26 15:19       ` Shivaprasad G Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=392247278.10124607.1706282995795.JavaMail.zimbra@raptorengineeringinc.com \
    --to=tpearson@raptorengineering.com \
    --cc=aik@amd.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=bgray@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=gbatra@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=sbhat@linux.ibm.com \
    --cc=vaibhav@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.