From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
Kevin Tian <kevin.tian@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Vinod Koul <vkoul@kernel.org>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v8 01/11] iommu: Add max_pasids field in struct iommu_device
Date: Fri, 10 Jun 2022 14:33:47 +0800 [thread overview]
Message-ID: <3923e5ab-a108-b82f-28ab-584ab0d562e4@linux.intel.com> (raw)
In-Reply-To: <20220609172542.GB33363@araj-dh-work>
On 2022/6/10 01:25, Raj, Ashok wrote:
>> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
>> index 4f29139bbfc3..e065cbe3c857 100644
>> --- a/include/linux/intel-iommu.h
>> +++ b/include/linux/intel-iommu.h
>> @@ -479,7 +479,6 @@ enum {
>> #define VTD_FLAG_IRQ_REMAP_PRE_ENABLED (1 << 1)
>> #define VTD_FLAG_SVM_CAPABLE (1 << 2)
>>
>> -extern int intel_iommu_sm;
>> extern spinlock_t device_domain_lock;
>>
>> #define sm_supported(iommu) (intel_iommu_sm && ecap_smts((iommu)->ecap))
>> @@ -786,6 +785,7 @@ struct context_entry *iommu_context_addr(struct intel_iommu *iommu, u8 bus,
>> extern const struct iommu_ops intel_iommu_ops;
>>
>> #ifdef CONFIG_INTEL_IOMMU
>> +extern int intel_iommu_sm;
>> extern int iommu_calculate_agaw(struct intel_iommu *iommu);
>> extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu);
>> extern int dmar_disabled;
>> @@ -802,6 +802,7 @@ static inline int iommu_calculate_max_sagaw(struct intel_iommu *iommu)
>> }
>> #define dmar_disabled (1)
>> #define intel_iommu_enabled (0)
>> +#define intel_iommu_sm (0)
> Is the above part of this patch? Or should be moved up somewhere?
This is to make pasid_supported() usable in dmar.c. It's only needed by
the change in this patch. I should make this clear in the commit
message. :-)
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Tian <kevin.tian@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v8 01/11] iommu: Add max_pasids field in struct iommu_device
Date: Fri, 10 Jun 2022 14:33:47 +0800 [thread overview]
Message-ID: <3923e5ab-a108-b82f-28ab-584ab0d562e4@linux.intel.com> (raw)
In-Reply-To: <20220609172542.GB33363@araj-dh-work>
On 2022/6/10 01:25, Raj, Ashok wrote:
>> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
>> index 4f29139bbfc3..e065cbe3c857 100644
>> --- a/include/linux/intel-iommu.h
>> +++ b/include/linux/intel-iommu.h
>> @@ -479,7 +479,6 @@ enum {
>> #define VTD_FLAG_IRQ_REMAP_PRE_ENABLED (1 << 1)
>> #define VTD_FLAG_SVM_CAPABLE (1 << 2)
>>
>> -extern int intel_iommu_sm;
>> extern spinlock_t device_domain_lock;
>>
>> #define sm_supported(iommu) (intel_iommu_sm && ecap_smts((iommu)->ecap))
>> @@ -786,6 +785,7 @@ struct context_entry *iommu_context_addr(struct intel_iommu *iommu, u8 bus,
>> extern const struct iommu_ops intel_iommu_ops;
>>
>> #ifdef CONFIG_INTEL_IOMMU
>> +extern int intel_iommu_sm;
>> extern int iommu_calculate_agaw(struct intel_iommu *iommu);
>> extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu);
>> extern int dmar_disabled;
>> @@ -802,6 +802,7 @@ static inline int iommu_calculate_max_sagaw(struct intel_iommu *iommu)
>> }
>> #define dmar_disabled (1)
>> #define intel_iommu_enabled (0)
>> +#define intel_iommu_sm (0)
> Is the above part of this patch? Or should be moved up somewhere?
This is to make pasid_supported() usable in dmar.c. It's only needed by
the change in this patch. I should make this clear in the commit
message. :-)
Best regards,
baolu
next prev parent reply other threads:[~2022-06-10 6:34 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 1:49 [PATCH v8 00/11] iommu: SVA and IOPF refactoring Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-07 1:49 ` [PATCH v8 01/11] iommu: Add max_pasids field in struct iommu_device Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-09 17:25 ` Raj, Ashok
2022-06-09 17:25 ` Raj, Ashok
2022-06-09 23:53 ` Jason Gunthorpe via iommu
2022-06-09 23:53 ` Jason Gunthorpe
2022-06-10 8:45 ` Tian, Kevin
2022-06-10 8:45 ` Tian, Kevin
2022-06-10 6:33 ` Baolu Lu [this message]
2022-06-10 6:33 ` Baolu Lu
2022-06-07 1:49 ` [PATCH v8 02/11] iommu: Add max_pasids field in struct dev_iommu Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-09 19:01 ` Raj, Ashok
2022-06-09 19:01 ` Raj, Ashok
2022-06-10 6:46 ` Baolu Lu
2022-06-10 6:46 ` Baolu Lu
2022-06-10 9:01 ` Tian, Kevin
2022-06-10 9:01 ` Tian, Kevin
2022-06-10 9:07 ` Baolu Lu
2022-06-10 9:07 ` Baolu Lu
2022-06-07 1:49 ` [PATCH v8 03/11] iommu: Remove SVM_FLAG_SUPERVISOR_MODE support Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-07 1:49 ` [PATCH v8 04/11] iommu: Add sva iommu_domain support Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-09 20:25 ` Raj, Ashok
2022-06-09 20:25 ` Raj, Ashok
2022-06-10 7:16 ` Baolu Lu
2022-06-10 7:16 ` Baolu Lu
2022-06-17 7:43 ` Tian, Kevin
2022-06-17 7:43 ` Tian, Kevin
2022-06-20 0:34 ` Baolu Lu
2022-06-20 0:34 ` Baolu Lu
2022-06-07 1:49 ` [PATCH v8 05/11] iommu/vt-d: Add SVA domain support Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-17 7:47 ` Tian, Kevin
2022-06-17 7:47 ` Tian, Kevin
2022-06-20 0:35 ` Baolu Lu
2022-06-20 0:35 ` Baolu Lu
2022-06-07 1:49 ` [PATCH v8 06/11] arm-smmu-v3/sva: " Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-07 1:49 ` [PATCH v8 07/11] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-07 1:49 ` [PATCH v8 08/11] iommu: Remove SVA related callbacks from iommu ops Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-07 1:49 ` [PATCH v8 09/11] iommu: Prepare IOMMU domain for IOPF Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-07 1:49 ` [PATCH v8 10/11] iommu: Per-domain I/O page fault handling Lu Baolu
2022-06-07 1:49 ` Lu Baolu
2022-06-07 1:49 ` [PATCH v8 11/11] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu
2022-06-07 1:49 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3923e5ab-a108-b82f-28ab-584ab0d562e4@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jean-philippe@linaro.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.