All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Trimarchi <trimarchimichael@yahoo.it>
To: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Andrew Victor <linux@maxim.org.za>,
	Anti Sullin <anti.sullin@artecdesign.ee>,
	Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Subject: Re: [PATCH] atmel_serial: update the powersave handler to match serial core
Date: Fri, 19 Sep 2008 15:33:44 +0000 (GMT)	[thread overview]
Message-ID: <393.6138.qm@web26208.mail.ukl.yahoo.com> (raw)

Hi,




> +    /* we can not wake up if we're running on slow clock */
> +    atmel_port->may_wakeup = device_may_wakeup(&pdev->dev);
> +    if (atmel_serial_clk_will_stop())
> +        device_set_wakeup_enable(&pdev->dev, 0);
> +
This is not true, the wakeup in the slow clock is possible, configure the
input pin of the serial device as a gpio, and wake up on gpio. Then you
must reconfigure as a serial pin, and you can wake up on slow clock.

Regards Michael

__________________________________________________
Do You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi 
http://mail.yahoo.it 

WARNING: multiple messages have this Message-ID (diff)
From: Michael Trimarchi <trimarchimichael@yahoo.it>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
	linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Andrew Victor <linux@maxim.org.za>,
	Anti Sullin <anti.sullin@artecdesign.ee>,
	Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Subject: Re: [PATCH] atmel_serial: update the powersave handler to match serial core
Date: Fri, 19 Sep 2008 15:33:44 +0000 (GMT)	[thread overview]
Message-ID: <393.6138.qm@web26208.mail.ukl.yahoo.com> (raw)

Hi,




> +    /* we can not wake up if we're running on slow clock */
> +    atmel_port->may_wakeup = device_may_wakeup(&pdev->dev);
> +    if (atmel_serial_clk_will_stop())
> +        device_set_wakeup_enable(&pdev->dev, 0);
> +
This is not true, the wakeup in the slow clock is possible, configure the
input pin of the serial device as a gpio, and wake up on gpio. Then you
must reconfigure as a serial pin, and you can wake up on slow clock.

Regards Michael

__________________________________________________
Do You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi 
http://mail.yahoo.it 

             reply	other threads:[~2008-09-19 15:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19 15:33 Michael Trimarchi [this message]
2008-09-19 15:33 ` [PATCH] atmel_serial: update the powersave handler to match serial core Michael Trimarchi
2008-09-19 15:46 ` Haavard Skinnemoen
  -- strict thread matches above, loose matches on Subject: below --
2008-09-20  9:31 Michael Trimarchi
2008-09-19 16:33 Michael Trimarchi
2008-09-19 16:33 ` Michael Trimarchi
2008-09-19 18:35 ` Haavard Skinnemoen
2008-09-19 21:49   ` Anti Sullin
2008-09-20 13:01     ` Haavard Skinnemoen
2008-09-19 16:01 Michael Trimarchi
2008-09-19 16:01 ` Michael Trimarchi
2008-09-19 16:15 ` Haavard Skinnemoen
2008-09-19 15:11 Haavard Skinnemoen
2008-09-19 15:19 ` Anti Sullin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=393.6138.qm@web26208.mail.ukl.yahoo.com \
    --to=trimarchimichael@yahoo.it \
    --cc=anti.sullin@artecdesign.ee \
    --cc=haavard.skinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@maxim.org.za \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.