All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Bin Liu <binmlist@gmail.com>,
	Brian Hutchinson <b.hutchman@gmail.com>,
	Felipe Balbi <balbi@ti.com>,
	Matthijs van Duin <matthijsvanduin@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: add dm816x dependency on USB_PHY
Date: Tue, 19 May 2015 15:02:28 +0200	[thread overview]
Message-ID: <3934365.TiRUES6WLp@wuerfel> (raw)

The newly added phy-dm816x-usb driver depends on the
usb phy API and fails to link if that is disabled:

drivers/built-in.o: In function `dm816x_usb_phy_remove':
:(.text+0x3a28): undefined reference to `usb_remove_phy'
drivers/built-in.o: In function `dm816x_usb_phy_probe':
:(.text+0x3c18): undefined reference to `usb_add_phy_dev'

This adds an explicit dependency in Kconfig to avoid the
build error in randconfig tests.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 609adde838f4 ("phy: Add a driver for dm816x USB PHY")

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index fceac96c2a31..1b5c235562c9 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY
 
 config PHY_DM816X_USB
 	tristate "TI dm816x USB PHY driver"
-	depends on ARCH_OMAP2PLUS
+	depends on ARCH_OMAP2PLUS && USB_PHY
 	select GENERIC_PHY
 	help
 	  Enable this for dm816x USB to work.

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: add dm816x dependency on USB_PHY
Date: Tue, 19 May 2015 15:02:28 +0200	[thread overview]
Message-ID: <3934365.TiRUES6WLp@wuerfel> (raw)

The newly added phy-dm816x-usb driver depends on the
usb phy API and fails to link if that is disabled:

drivers/built-in.o: In function `dm816x_usb_phy_remove':
:(.text+0x3a28): undefined reference to `usb_remove_phy'
drivers/built-in.o: In function `dm816x_usb_phy_probe':
:(.text+0x3c18): undefined reference to `usb_add_phy_dev'

This adds an explicit dependency in Kconfig to avoid the
build error in randconfig tests.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 609adde838f4 ("phy: Add a driver for dm816x USB PHY")

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index fceac96c2a31..1b5c235562c9 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY
 
 config PHY_DM816X_USB
 	tristate "TI dm816x USB PHY driver"
-	depends on ARCH_OMAP2PLUS
+	depends on ARCH_OMAP2PLUS && USB_PHY
 	select GENERIC_PHY
 	help
 	  Enable this for dm816x USB to work.

             reply	other threads:[~2015-05-19 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 13:02 Arnd Bergmann [this message]
2015-05-19 13:02 ` [PATCH] phy: add dm816x dependency on USB_PHY Arnd Bergmann
2015-05-19 13:29 ` Kishon Vijay Abraham I
2015-05-19 13:29   ` Kishon Vijay Abraham I
2015-05-19 13:29   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3934365.TiRUES6WLp@wuerfel \
    --to=arnd@arndb.de \
    --cc=b.hutchman@gmail.com \
    --cc=balbi@ti.com \
    --cc=binmlist@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=matthijsvanduin@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.