From: Vignesh Raghavendra <vigneshr@ti.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-mcu: remove incorrect UART base clock rates
Date: Fri, 22 Apr 2022 14:18:43 +0530 [thread overview]
Message-ID: <39358e53-e083-4e2c-a35c-d362e4cd4e5c@ti.com> (raw)
In-Reply-To: <20220419075157.189347-1-matthias.schiffer@ew.tq-group.com>
Hi,
On 19/04/22 1:21 pm, Matthias Schiffer wrote:
> We found that (at least some versions of) the sci-fw set the base clock
> rate for UARTs in the MCU domain to 96 MHz instead of the expected 48 MHz,
> leading to incorrect baud rates when used from Linux.
>
> As the 8250_omap driver will query the actual clock rate from the clk
> driver when clock-frequency is unset, removing the incorrect property is
> sufficient to fix the baud rate.
>
> Fixes: 8abae9389bdb ("arm64: dts: ti: Add support for AM642 SoC")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
>
> v2: remove incorrect clock-frequency instead of using
> assigned-clock-rates to modify the base clock
>
> arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi
> index 2bb5c9ff172c..02d4285acbb8 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi
> @@ -10,7 +10,6 @@ mcu_uart0: serial@4a00000 {
> compatible = "ti,am64-uart", "ti,am654-uart";
> reg = <0x00 0x04a00000 0x00 0x100>;
> interrupts = <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>;
> - clock-frequency = <48000000>;
> current-speed = <115200>;
> power-domains = <&k3_pds 149 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 149 0>;
> @@ -21,7 +20,6 @@ mcu_uart1: serial@4a10000 {
> compatible = "ti,am64-uart", "ti,am654-uart";
> reg = <0x00 0x04a10000 0x00 0x100>;
> interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> - clock-frequency = <48000000>;
> current-speed = <115200>;
> power-domains = <&k3_pds 160 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 160 0>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-mcu: remove incorrect UART base clock rates
Date: Fri, 22 Apr 2022 14:18:43 +0530 [thread overview]
Message-ID: <39358e53-e083-4e2c-a35c-d362e4cd4e5c@ti.com> (raw)
In-Reply-To: <20220419075157.189347-1-matthias.schiffer@ew.tq-group.com>
Hi,
On 19/04/22 1:21 pm, Matthias Schiffer wrote:
> We found that (at least some versions of) the sci-fw set the base clock
> rate for UARTs in the MCU domain to 96 MHz instead of the expected 48 MHz,
> leading to incorrect baud rates when used from Linux.
>
> As the 8250_omap driver will query the actual clock rate from the clk
> driver when clock-frequency is unset, removing the incorrect property is
> sufficient to fix the baud rate.
>
> Fixes: 8abae9389bdb ("arm64: dts: ti: Add support for AM642 SoC")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
>
> v2: remove incorrect clock-frequency instead of using
> assigned-clock-rates to modify the base clock
>
> arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi
> index 2bb5c9ff172c..02d4285acbb8 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi
> @@ -10,7 +10,6 @@ mcu_uart0: serial@4a00000 {
> compatible = "ti,am64-uart", "ti,am654-uart";
> reg = <0x00 0x04a00000 0x00 0x100>;
> interrupts = <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>;
> - clock-frequency = <48000000>;
> current-speed = <115200>;
> power-domains = <&k3_pds 149 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 149 0>;
> @@ -21,7 +20,6 @@ mcu_uart1: serial@4a10000 {
> compatible = "ti,am64-uart", "ti,am654-uart";
> reg = <0x00 0x04a10000 0x00 0x100>;
> interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> - clock-frequency = <48000000>;
> current-speed = <115200>;
> power-domains = <&k3_pds 160 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 160 0>;
next prev parent reply other threads:[~2022-04-22 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 7:51 [PATCH v2] arm64: dts: ti: k3-am64-mcu: remove incorrect UART base clock rates Matthias Schiffer
2022-04-19 7:51 ` Matthias Schiffer
2022-04-22 8:48 ` Vignesh Raghavendra [this message]
2022-04-22 8:48 ` Vignesh Raghavendra
2022-04-27 15:17 ` Vignesh Raghavendra
2022-04-27 15:17 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39358e53-e083-4e2c-a35c-d362e4cd4e5c@ti.com \
--to=vigneshr@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.