[dpdk-dev] [PATCH 1/5] raw/dpaa2_qdma: fix spin lock release condition

[dpdk-dev] [PATCH 1/5] raw/dpaa2_qdma: fix spin lock release condition

[Hemant Agrawal]

The code shall be unlock post the lock.

Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index a41c1e385..102d423c6 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -984,7 +984,7 @@ rte_qdma_vq_destroy(uint16_t vq_id)
 
 	memset(qdma_vq, 0, sizeof(struct qdma_virt_queue));
 
-	rte_spinlock_lock(&qdma_dev.lock);
+	rte_spinlock_unlock(&qdma_dev.lock);
 
 	return 0;
 }
-- 
2.17.1

[dpdk-dev] [PATCH 2/5] raw/dpaa2_qdma: fix spin lock

[Hemant Agrawal]

This shall be unlock post the lock

Fixes: 4d9a3f2a0159 ("raw/dpaa2_qdma: support RBP mode")

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index 102d423c6..a391913b0 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -1013,7 +1013,7 @@ rte_qdma_vq_destroy_rbp(uint16_t vq_id)
 
 	memset(qdma_vq, 0, sizeof(struct qdma_virt_queue));
 
-	rte_spinlock_lock(&qdma_dev.lock);
+	rte_spinlock_unlock(&qdma_dev.lock);
 
 	return 0;
 }
-- 
2.17.1

[dpdk-dev] [PATCH 3/5] net/dpaa2: fix the loopback spelling

[Hemant Agrawal]

Fixes: a3a997f02d07 ("net/dpaa2: support low level loopback tester")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 89d20d0bf..900182f66 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -28,7 +28,7 @@
 #include "dpaa2_ethdev.h"
 #include <fsl_qbman_debug.h>
 
-#define DRIVER_LOOPBACK_MODE "drv_looback"
+#define DRIVER_LOOPBACK_MODE "drv_loopback"
 
 /* Supported Rx offloads */
 static uint64_t dev_rx_offloads_sup =
-- 
2.17.1

[dpdk-dev] [PATCH 4/5] doc: update the dpaaX platform guides

[Hemant Agrawal]

Update the dpaa platform guides with latest SDK dependency.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 doc/guides/cryptodevs/dpaa2_sec.rst | 4 ++--
 doc/guides/eventdevs/dpaa2.rst      | 4 ++--
 doc/guides/nics/dpaa.rst            | 1 +
 doc/guides/nics/dpaa2.rst           | 5 ++---
 doc/guides/platform/dpaa2.rst       | 4 ++--
 doc/guides/rawdevs/dpaa2_cmdif.rst  | 4 ++--
 doc/guides/rawdevs/dpaa2_qdma.rst   | 4 ++--
 7 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/doc/guides/cryptodevs/dpaa2_sec.rst b/doc/guides/cryptodevs/dpaa2_sec.rst
index 21cb00360..9e21d3169 100644
--- a/doc/guides/cryptodevs/dpaa2_sec.rst
+++ b/doc/guides/cryptodevs/dpaa2_sec.rst
@@ -161,8 +161,8 @@ See :doc:`../platform/dpaa2` for setup information
 
 Currently supported by DPDK:
 
-- NXP SDK **18.09+**.
-- MC Firmware version **10.10.0** and higher.
+- NXP SDK **19.03+**.
+- MC Firmware version **10.14.0** and higher.
 - Supported architectures:  **arm64 LE**.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
diff --git a/doc/guides/eventdevs/dpaa2.rst b/doc/guides/eventdevs/dpaa2.rst
index 332b1a31c..a24a43c15 100644
--- a/doc/guides/eventdevs/dpaa2.rst
+++ b/doc/guides/eventdevs/dpaa2.rst
@@ -38,8 +38,8 @@ See :doc:`../platform/dpaa2` for setup information
 
 Currently supported by DPDK:
 
-- NXP SDK **18.09+**.
-- MC Firmware version **10.10.0** and higher.
+- NXP SDK **19.03+**.
+- MC Firmware version **10.14.0** and higher.
 - Supported architectures:  **arm64 LE**.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
diff --git a/doc/guides/nics/dpaa.rst b/doc/guides/nics/dpaa.rst
index fb7bc7d0c..cd35cabde 100644
--- a/doc/guides/nics/dpaa.rst
+++ b/doc/guides/nics/dpaa.rst
@@ -253,6 +253,7 @@ state during application initialization:
   choose to change their number if HW portals are limited.
   The valid values are from '0' to '4'. The valuse shall be set to '0' if the
   application want to use eventdev with DPAA device.
+  Currently these queues are not used for LS1023/LS1043 platform by default.
 
 
 Driver compilation and testing
diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst
index d74d8f899..10b9d7dff 100644
--- a/doc/guides/nics/dpaa2.rst
+++ b/doc/guides/nics/dpaa2.rst
@@ -421,7 +421,7 @@ See :doc:`../platform/dpaa2` for setup information
 
 Currently supported by DPDK:
 
-- NXP SDK **18.11+**.
+- NXP LSDK **19.03+**.
 - MC Firmware version **10.14.0** and higher.
 - Supported architectures:  **arm64 LE**.
 
@@ -502,7 +502,7 @@ for details.
 
 * Use dev arg option ``drv_loopback=1`` to loopback packets at
   driver level. Any packet received will be reflected back by the
-  driver on same port.
+  driver on same port. e.g. ``fslmc:dpni.1,drv_loopback=1``
 
 Enabling logs
 -------------
@@ -557,4 +557,3 @@ Other Limitations
 
 - RSS hash key cannot be modified.
 - RSS RETA cannot be configured.
-- Secondary process packet I/O is not supported.
diff --git a/doc/guides/platform/dpaa2.rst b/doc/guides/platform/dpaa2.rst
index 5a64406eb..82aae0ab2 100644
--- a/doc/guides/platform/dpaa2.rst
+++ b/doc/guides/platform/dpaa2.rst
@@ -101,8 +101,8 @@ separately:
 
 Currently supported by DPDK:
 
-- NXP SDK **2.0+** (preferred: LSDK 18.09).
-- MC Firmware version **10.10.0** and higher.
+- NXP SDK **2.0+** (preferred: LSDK 19.03).
+- MC Firmware version **10.14.0** and higher.
 - Supported architectures:  **arm64 LE**.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>`
diff --git a/doc/guides/rawdevs/dpaa2_cmdif.rst b/doc/guides/rawdevs/dpaa2_cmdif.rst
index 6db06777c..ac5f0f137 100644
--- a/doc/guides/rawdevs/dpaa2_cmdif.rst
+++ b/doc/guides/rawdevs/dpaa2_cmdif.rst
@@ -33,8 +33,8 @@ See :doc:`../platform/dpaa2` for setup information
 
 Currently supported by DPDK:
 
-- NXP SDK **18.09+**.
-- MC Firmware version **10.10.0** and higher.
+- NXP SDK **19.03+**.
+- MC Firmware version **10.14.0** and higher.
 - Supported architectures:  **arm64 LE**.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
diff --git a/doc/guides/rawdevs/dpaa2_qdma.rst b/doc/guides/rawdevs/dpaa2_qdma.rst
index 359e4c69f..1550ca5ba 100644
--- a/doc/guides/rawdevs/dpaa2_qdma.rst
+++ b/doc/guides/rawdevs/dpaa2_qdma.rst
@@ -37,8 +37,8 @@ See :doc:`../platform/dpaa2` for setup information
 
 Currently supported by DPDK:
 
-- NXP SDK **18.09+**.
-- MC Firmware version **10.10.0** and higher.
+- NXP SDK **19.03+**.
+- MC Firmware version **10.14.0** and higher.
 - Supported architectures:  **arm64 LE**.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
-- 
2.17.1

Re: [dpdk-dev] [PATCH 4/5] doc: update the dpaaX platform guides

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal
> Sent: Wednesday, April 24, 2019 12:45 PM
> To: dev@dpdk.org
> Cc: shreyansh.jain@nxp.com
> Subject: [dpdk-dev] [PATCH 4/5] doc: update the dpaaX platform guides
> 
> Update the dpaa platform guides with latest SDK dependency.
> 

Acked-by: John McNamara <john.mcnamara@intel.com>

[dpdk-dev] [PATCH 5/5] raw/dpaa2_cmdif: remove driver name assignment

[Hemant Agrawal]

vdev driver names are not available in create if called from probe.

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c         | 1 -
 drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 7d311b2ee..0ed333850 100644
--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -207,7 +207,6 @@ dpaa2_cmdif_create(const char *name,
 
 	rawdev->dev_ops = &dpaa2_cmdif_ops;
 	rawdev->device = &vdev->device;
-	rawdev->driver_name = vdev->device.driver->name;
 
 	/* For secondary processes, the primary has done all the work */
 	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
index d7630fc69..ccf08cc82 100644
--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
@@ -585,7 +585,6 @@ skeleton_rawdev_create(const char *name,
 
 	rawdev->dev_ops = &skeleton_rawdev_ops;
 	rawdev->device = &vdev->device;
-	rawdev->driver_name = vdev->device.driver->name;
 
 	skeldev = skeleton_rawdev_get_priv(rawdev);
 
-- 
2.17.1

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/5] raw/dpaa2_qdma: fix spin lock release condition

[Thomas Monjalon]

24/04/2019 13:45, Hemant Agrawal:
> The code shall be unlock post the lock.
> 
> Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Series applied, thanks