From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND][PATCH] ARM: debug: add support for Palmchip 16550-like UART
Date: Wed, 04 Nov 2015 21:39:46 +0100 [thread overview]
Message-ID: <3941204.6gDbSNijjW@wuerfel> (raw)
In-Reply-To: <1445950678-16097-1-git-send-email-mans@mansr.com>
On Tuesday 27 October 2015 12:57:57 Mans Rullgard wrote:
> --- a/arch/arm/include/debug/8250.S
> +++ b/arch/arm/include/debug/8250.S
> @@ -9,6 +9,18 @@
> */
> #include <linux/serial_reg.h>
>
> +#ifdef CONFIG_DEBUG_UART_8250_PALMCHIP
> +
> +#undef UART_TX
> +#undef UART_LSR
> +#undef UART_MSR
> +
> +#define UART_TX 1
> +#define UART_LSR 7
> +#define UART_MSR 8
> +
> +#endif
>
Maybe use a separate file instead of an #ifdef?
Something like
arch/arm/include/debug/8250-palmchip.S:
#include <linux/serial_reg.h>
#undef UART_TX
#undef UART_LSR
#undef UART_MSR
#define UART_TX 1
#define UART_LSR 7
#define UART_MSR 8
#include "8250.S"
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Mans Rullgard <mans@mansr.com>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH] ARM: debug: add support for Palmchip 16550-like UART
Date: Wed, 04 Nov 2015 21:39:46 +0100 [thread overview]
Message-ID: <3941204.6gDbSNijjW@wuerfel> (raw)
In-Reply-To: <1445950678-16097-1-git-send-email-mans@mansr.com>
On Tuesday 27 October 2015 12:57:57 Mans Rullgard wrote:
> --- a/arch/arm/include/debug/8250.S
> +++ b/arch/arm/include/debug/8250.S
> @@ -9,6 +9,18 @@
> */
> #include <linux/serial_reg.h>
>
> +#ifdef CONFIG_DEBUG_UART_8250_PALMCHIP
> +
> +#undef UART_TX
> +#undef UART_LSR
> +#undef UART_MSR
> +
> +#define UART_TX 1
> +#define UART_LSR 7
> +#define UART_MSR 8
> +
> +#endif
>
Maybe use a separate file instead of an #ifdef?
Something like
arch/arm/include/debug/8250-palmchip.S:
#include <linux/serial_reg.h>
#undef UART_TX
#undef UART_LSR
#undef UART_MSR
#define UART_TX 1
#define UART_LSR 7
#define UART_MSR 8
#include "8250.S"
Arnd
next prev parent reply other threads:[~2015-11-04 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 12:57 [RESEND][PATCH] ARM: debug: add support for Palmchip 16550-like UART Mans Rullgard
2015-10-27 12:57 ` Mans Rullgard
2015-11-04 15:39 ` Mason
2015-11-04 15:39 ` Mason
2015-11-04 15:47 ` Måns Rullgård
2015-11-04 15:47 ` Måns Rullgård
2015-11-04 15:59 ` Mason
2015-11-04 15:59 ` Mason
2015-11-04 16:08 ` Måns Rullgård
2015-11-04 16:08 ` Måns Rullgård
2015-11-04 20:39 ` Arnd Bergmann [this message]
2015-11-04 20:39 ` Arnd Bergmann
2015-11-04 21:41 ` Måns Rullgård
2015-11-04 21:41 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3941204.6gDbSNijjW@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.