From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu: Fix deferred domain attachment in iommu_probe_device()
Date: Wed, 4 Nov 2020 09:01:22 +0800 [thread overview]
Message-ID: <399fbf3e-e940-d2a3-e0e7-20f4da988184@linux.intel.com> (raw)
In-Reply-To: <20201103132358.GG22888@8bytes.org>
Hi Joerg,
On 11/3/20 9:23 PM, Joerg Roedel wrote:
> Hi Baolu,
>
> On Mon, Oct 26, 2020 at 02:30:08PM +0800, Lu Baolu wrote:
>> @@ -264,7 +266,8 @@ int iommu_probe_device(struct device *dev)
>> */
>> iommu_alloc_default_domain(group, dev);
>>
>> - if (group->default_domain)
>> + if (group->default_domain &&
>> + !iommu_is_attach_deferred(group->default_domain, dev))
>> ret = __iommu_attach_device(group->default_domain, dev);
>
> This is the hotplug path, not used for boot-initialization. Have you
> seen failures from the missing check here?
I haven't seen any failure. Just wondered why deferred attaching was not
checked here. It's fine to me if it's only for hotplug path.
Please ignore this change.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu: Fix deferred domain attachment in iommu_probe_device()
Date: Wed, 4 Nov 2020 09:01:22 +0800 [thread overview]
Message-ID: <399fbf3e-e940-d2a3-e0e7-20f4da988184@linux.intel.com> (raw)
In-Reply-To: <20201103132358.GG22888@8bytes.org>
Hi Joerg,
On 11/3/20 9:23 PM, Joerg Roedel wrote:
> Hi Baolu,
>
> On Mon, Oct 26, 2020 at 02:30:08PM +0800, Lu Baolu wrote:
>> @@ -264,7 +266,8 @@ int iommu_probe_device(struct device *dev)
>> */
>> iommu_alloc_default_domain(group, dev);
>>
>> - if (group->default_domain)
>> + if (group->default_domain &&
>> + !iommu_is_attach_deferred(group->default_domain, dev))
>> ret = __iommu_attach_device(group->default_domain, dev);
>
> This is the hotplug path, not used for boot-initialization. Have you
> seen failures from the missing check here?
I haven't seen any failure. Just wondered why deferred attaching was not
checked here. It's fine to me if it's only for hotplug path.
Please ignore this change.
Best regards,
baolu
next prev parent reply other threads:[~2020-11-04 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 6:30 [PATCH 1/1] iommu: Fix deferred domain attachment in iommu_probe_device() Lu Baolu
2020-10-26 6:30 ` Lu Baolu
2020-11-03 13:23 ` Joerg Roedel
2020-11-03 13:23 ` Joerg Roedel
2020-11-04 1:01 ` Lu Baolu [this message]
2020-11-04 1:01 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=399fbf3e-e940-d2a3-e0e7-20f4da988184@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.