From: Jan Beulich <jbeulich@suse.com>
To: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration
Date: Tue, 22 Jul 2025 15:35:49 +0200 [thread overview]
Message-ID: <39cc57c3-cf46-472d-9b66-4ecf9641c5e5@suse.com> (raw)
In-Reply-To: <DBIMDD208BKM.29K5RWGMS48QS@amd.com>
On 22.07.2025 15:31, Alejandro Vallejo wrote:
> On Tue Jul 22, 2025 at 2:57 PM CEST, Jan Beulich wrote:
>> On 22.07.2025 14:37, Alejandro Vallejo wrote:
>>> On Tue Jul 22, 2025 at 2:18 PM CEST, Jan Beulich wrote:
>>>> On 22.07.2025 13:59, Alejandro Vallejo wrote:
>>>>> Reduce the scope of every variable so they are reinitialised. "iommu",
>>>>> for instance, isn't being cleared, so the wrong flags may make it to
>>>>> domains that should not have them.
>>>>
>>>> Yet "for instance" isn't quite right, is it? "iommu" is the only one where
>>>> the (re)init was misplaced. The other two ...
>>>
>>> We do strive for minimal scope where possible. But you're right "for instance"
>>> might be misleading in suggesting there's more bugs than one.
>>>
>>> I'm happy to have "for instance" removed, leaving the rest as-is, if that works
>>> for you.
>>
>> Except that "every" isn't quite right either. Nor is "they".
>
> Ok, take 3:
>
> Reduce the scope of dom0less_iommu, iommu and cpupool_node. iommu, in
> particular, wasn't being cleared, so the wrong flags may make it to
> domains that should not have them.
Fine with me, thanks.
Jan
next prev parent reply other threads:[~2025-07-22 13:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:59 [PATCH 00/10] Extract bindings in dom0less code Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 01/10] static-evtchn: Add missing include Alejandro Vallejo
2025-07-22 12:10 ` Jan Beulich
2025-07-22 12:41 ` Alejandro Vallejo
2025-07-22 23:22 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 02/10] dt: Add cf_check to device-tree.c function pointers Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 03/10] dom0less: Move asm-generic/dom0less-build.h -> xen/dom0less-build.h Alejandro Vallejo
2025-07-22 23:25 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 04/10] bootfdt: Add createdomain arguments to boot_domain Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 05/10] dom0less: Introduce kernel_info into the domain creation loop Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 06/10] dom0less: Create llc_color_str field in boot_domain Alejandro Vallejo
2025-07-22 23:29 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 07/10] dom0less: Turn arch_create_domUs into arch_parse_dom0less_node() Alejandro Vallejo
2025-07-22 23:33 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 08/10] dom0less: Allow arch_parse_dom0less_node() to be fallible Alejandro Vallejo
2025-07-22 23:32 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration Alejandro Vallejo
2025-07-22 12:18 ` Jan Beulich
2025-07-22 12:37 ` Alejandro Vallejo
2025-07-22 12:57 ` Jan Beulich
2025-07-22 13:31 ` Alejandro Vallejo
2025-07-22 13:35 ` Jan Beulich [this message]
2025-07-22 23:36 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 10/10] dom0less: Parse dom0less bindings into createdomain input args Alejandro Vallejo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39cc57c3-cf46-472d-9b66-4ecf9641c5e5@suse.com \
--to=jbeulich@suse.com \
--cc=alejandro.garciavallejo@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=dpsmith@apertussolutions.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.