From: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Alejandro Vallejo <agarciav@amd.com>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
Jason Andryuk <jason.andryuk@amd.com>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 01/10] static-evtchn: Add missing include
Date: Tue, 22 Jul 2025 14:41:43 +0200 [thread overview]
Message-ID: <DBILBC1UJ0QZ.2KU2PDGDO14H9@amd.com> (raw)
In-Reply-To: <c72a8ff3-e3e3-437d-b169-031571a18dcc@suse.com>
On Tue Jul 22, 2025 at 2:10 PM CEST, Jan Beulich wrote:
> On 22.07.2025 13:59, Alejandro Vallejo wrote:
>> From: Alejandro Vallejo <agarciav@amd.com>
>>
>> When later on x86 starts using this file in later patches it won't find
>> device_tree.h because it's only transitively included by arm.
>>
>> Make it explicit.
>>
>> Not a functional change.
>>
>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
>> Acked-by: Stefano Stabellini <stefano.stabellini@amd.com>
>> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
>
> I'm certainly happy to trust you, but on a v1 submission I'm a little
> surprised to find two tags present already.
>
> Jan
They came out of internal review, and I didn't really want to drop them.
Everyone with tags is in CC, as auto-cc "helpfully" does in the absence of
further arguments (for better or worse), so they can pitch in.
If this is a problem, I'll make a note to drop internal tags before public
submissions in the future, and feel very free to ignore these. I do understand
it's important to keep proper paper trail, which, by doing this, is lost.
Cheers,
Alejandro
next prev parent reply other threads:[~2025-07-22 12:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:59 [PATCH 00/10] Extract bindings in dom0less code Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 01/10] static-evtchn: Add missing include Alejandro Vallejo
2025-07-22 12:10 ` Jan Beulich
2025-07-22 12:41 ` Alejandro Vallejo [this message]
2025-07-22 23:22 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 02/10] dt: Add cf_check to device-tree.c function pointers Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 03/10] dom0less: Move asm-generic/dom0less-build.h -> xen/dom0less-build.h Alejandro Vallejo
2025-07-22 23:25 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 04/10] bootfdt: Add createdomain arguments to boot_domain Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 05/10] dom0less: Introduce kernel_info into the domain creation loop Alejandro Vallejo
2025-07-22 11:59 ` [PATCH 06/10] dom0less: Create llc_color_str field in boot_domain Alejandro Vallejo
2025-07-22 23:29 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 07/10] dom0less: Turn arch_create_domUs into arch_parse_dom0less_node() Alejandro Vallejo
2025-07-22 23:33 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 08/10] dom0less: Allow arch_parse_dom0less_node() to be fallible Alejandro Vallejo
2025-07-22 23:32 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration Alejandro Vallejo
2025-07-22 12:18 ` Jan Beulich
2025-07-22 12:37 ` Alejandro Vallejo
2025-07-22 12:57 ` Jan Beulich
2025-07-22 13:31 ` Alejandro Vallejo
2025-07-22 13:35 ` Jan Beulich
2025-07-22 23:36 ` Stefano Stabellini
2025-07-22 11:59 ` [PATCH 10/10] dom0less: Parse dom0less bindings into createdomain input args Alejandro Vallejo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBILBC1UJ0QZ.2KU2PDGDO14H9@amd.com \
--to=alejandro.garciavallejo@amd.com \
--cc=agarciav@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=dpsmith@apertussolutions.com \
--cc=jason.andryuk@amd.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.