[linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[John DeFranco]

Hi,

I'm having a problem doing a pvcreate on a raid
device. It fails with:

[root@ham 0.9]# pvcreate -v /dev/md0
pvcreate -- locking logical volume manager
pvcreate -- checking physical volume name "/dev/md0"
pvcreate -- getting physical volume size
pvcreate -- checking partition type
pvcreate -- invalid partition type 0x83 for "/dev/md0" (must
be 0x8e)

I had this problem with the 0.8final but was pointed to
a suse lvm user tools rpm (lvm-0.8-70-i386.rpm) that worked
great. 

Now with the 0.9 tools the issue is here again. Is there
a fix for this (since I don't think I should use the
0.8 suse tools with 0.9 lvm)?

Thanks.
-- 
==========
Cheers
   -jdf

Re: [linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[Luca Berra]

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On Tue, Nov 28, 2000 at 07:51:47PM -0800, John DeFranco wrote:
> Hi,
> 
> I'm having a problem doing a pvcreate on a raid
> device. It fails with:
you should apply the attached patch
but thre is another problem:
vgscan will fail in pv_read
since pv_read.c contains a line which makes it fail if the device is an
me device.

0.8.1 has the same line, but pvread s not calle d by vgscan :)

heinz is there any reason for the code in pv-read.c to exist?

L.

-- 
Luca Berra -- bluca@comedia.it
    Communication Media & Services S.r.l.

[-- Attachment #2: Type: message/rfc822, Size: 2310 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 268 bytes --]


-- 
Luca Berra -- bluca@vodka.it
    PGP/GPG Public keys available via keyservers
      DSA: DA24 D16D 05FE A144 7762  BAF8 9307 A167 64C6 3A61
      ElG: 0429 0E81 F546 A3F5 726A  4789 802B 3464 48DF A653
      RSA: 6E 85 91 CA 4D 3B 36 2D  7F DB B1 39 D8 99 CC E6


[-- Attachment #2.1.2: LVM-0.9-lib-pv_get_size.diff --]
[-- Type: text/plain, Size: 1013 bytes --]

--- lib/pv_get_size.c.bluca	Mon Nov 13 01:20:11 2000
+++ lib/pv_get_size.c	Sun Nov 26 10:53:09 2000
@@ -87,6 +87,7 @@
       goto pv_get_size_end;
    }
 
+   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
    if ( ( cache_entry = lvm_dir_cache_find ( dev_name)) != NULL) {
       if ( lvm_check_partitioned_dev ( cache_entry->st_rdev) == TRUE) {
          st_rdev = cache_entry->st_rdev -
@@ -96,14 +97,14 @@
             if ( dir_cache[i].st_rdev == st_rdev)
                break;
          }
-      }
+         strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
+      } else {
+         strncpy ( disk_dev_name, dev_name, sizeof ( disk_dev_name) - 1);
+	  }
    } else {
       ret = -LVM_EPV_GET_SIZE_LVM_DIR_CACHE;
       goto pv_get_size_end;
    }
-
-   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
-   strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
 
    first = 1;
    if ( ( pv_handle = open ( disk_dev_name, O_RDONLY)) == -1) {

Re: [linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[Andreas Dilger]

Luca writes:
> you should apply the attached patch

Heinz, I believe this patch was also included in my 0.8 patchset, but
was dropped from 0.8.1...

Cheers, Andreas
===========================================================================
--- lib/pv_get_size.c.bluca	Mon Nov 13 01:20:11 2000
+++ lib/pv_get_size.c	Sun Nov 26 10:53:09 2000
@@ -87,6 +87,7 @@
       goto pv_get_size_end;
    }
 
+   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
    if ( ( cache_entry = lvm_dir_cache_find ( dev_name)) != NULL) {
       if ( lvm_check_partitioned_dev ( cache_entry->st_rdev) == TRUE) {
          st_rdev = cache_entry->st_rdev -
@@ -96,14 +97,14 @@
             if ( dir_cache[i].st_rdev == st_rdev)
                break;
          }
-      }
+         strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
+      } else {
+         strncpy ( disk_dev_name, dev_name, sizeof ( disk_dev_name) - 1);
+	  }
    } else {
       ret = -LVM_EPV_GET_SIZE_LVM_DIR_CACHE;
       goto pv_get_size_end;
    }
-
-   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
-   strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
 
    first = 1;
    if ( ( pv_handle = open ( disk_dev_name, O_RDONLY)) == -1) {
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

Re: [linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[Heinz J. Mauelshagen]

On Wed, Nov 29, 2000 at 11:49:23AM -0700, Andreas Dilger wrote:
> Luca writes:
> > you should apply the attached patch
> 
> Heinz, I believe this patch was also included in my 0.8 patchset, but
> was dropped from 0.8.1...

Sorry?

Already reintegrated it for 0.8.2.


> 
> Cheers, Andreas
> ===========================================================================
> --- lib/pv_get_size.c.bluca	Mon Nov 13 01:20:11 2000
> +++ lib/pv_get_size.c	Sun Nov 26 10:53:09 2000
> @@ -87,6 +87,7 @@
>        goto pv_get_size_end;
>     }
>  
> +   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
>     if ( ( cache_entry = lvm_dir_cache_find ( dev_name)) != NULL) {
>        if ( lvm_check_partitioned_dev ( cache_entry->st_rdev) == TRUE) {
>           st_rdev = cache_entry->st_rdev -
> @@ -96,14 +97,14 @@
>              if ( dir_cache[i].st_rdev == st_rdev)
>                 break;
>           }
> -      }
> +         strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
> +      } else {
> +         strncpy ( disk_dev_name, dev_name, sizeof ( disk_dev_name) - 1);
> +	  }
>     } else {
>        ret = -LVM_EPV_GET_SIZE_LVM_DIR_CACHE;
>        goto pv_get_size_end;
>     }
> -
> -   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
> -   strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
>  
>     first = 1;
>     if ( ( pv_handle = open ( disk_dev_name, O_RDONLY)) == -1) {
> -- 
> Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
>                  \  would they cancel out, leaving him still hungry?"
> http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm

-- 

Regards,
Heinz      -- The LVM guy --

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Bartningstr. 12
                                                  64289 Darmstadt
                                                  Germany
Mauelshagen@Sistina.com                           +49 6151 7103 86
                                                       FAX 7103 96
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[Heinz J. Mauelshagen]

On Wed, Nov 29, 2000 at 05:49:52PM +0100, Luca Berra wrote:
> On Tue, Nov 28, 2000 at 07:51:47PM -0800, John DeFranco wrote:
> > Hi,
> > 
> > I'm having a problem doing a pvcreate on a raid
> > device. It fails with:
> you should apply the attached patch
> but thre is another problem:
> vgscan will fail in pv_read
> since pv_read.c contains a line which makes it fail if the device is an
> me device.

It's used to distinguish in a higher library layer between MD and other devices.

> 
> 0.8.1 has the same line, but pvread s not calle d by vgscan :)

It gets called indirectly from from vgscan by calling vg_read_with_pv_and_lv().

> 
> heinz is there any reason for the code in pv-read.c to exist?
> 
> L.
> 
> -- 
> Luca Berra -- bluca@comedia.it
>     Communication Media & Services S.r.l.

> Return-Path: <bluca@vodka.it>
> Delivered-To: bluca@comedia.it
> Received: from Moskowskaya.vodka.it (Moskowskaya.vodka.it [213.246.0.200])
> 	by colombina.comedia.it (Postfix) with ESMTP id D04DB506D
> 	for <bluca@comedia.it>; Sun, 26 Nov 2000 10:04:12 +0000 ()
> Received: by Moskowskaya.vodka.it (Postfix, from userid 500)
> 	id 575EDCB15; Sun, 26 Nov 2000 11:04:04 +0100 (CET)
> Date: Sun, 26 Nov 2000 11:04:04 +0100
> From: Luca Berra <bluca@vodka.it>
> To: bluca@comedia.it
> Subject: LVM09
> Message-ID: <20001126110404.A11052@Moskowskaya.vodka.it>
> Reply-To: bluca@vodka.it
> Mime-Version: 1.0
> Content-Type: multipart/mixed; boundary="u3/rZRmxL6MmkK24"
> Content-Disposition: inline
> User-Agent: Mutt/1.2.5i
> X-Operating-System: Linux Moskowskaya 2.4.0-test8 i586
> Return-Receipt-To: bluca@vodka.it
> 
> 
> -- 
> Luca Berra -- bluca@vodka.it
>     PGP/GPG Public keys available via keyservers
>       DSA: DA24 D16D 05FE A144 7762  BAF8 9307 A167 64C6 3A61
>       ElG: 0429 0E81 F546 A3F5 726A  4789 802B 3464 48DF A653
>       RSA: 6E 85 91 CA 4D 3B 36 2D  7F DB B1 39 D8 99 CC E6
> 

> --- lib/pv_get_size.c.bluca	Mon Nov 13 01:20:11 2000
> +++ lib/pv_get_size.c	Sun Nov 26 10:53:09 2000
> @@ -87,6 +87,7 @@
>        goto pv_get_size_end;
>     }
>  
> +   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
>     if ( ( cache_entry = lvm_dir_cache_find ( dev_name)) != NULL) {
>        if ( lvm_check_partitioned_dev ( cache_entry->st_rdev) == TRUE) {
>           st_rdev = cache_entry->st_rdev -
> @@ -96,14 +97,14 @@
>              if ( dir_cache[i].st_rdev == st_rdev)
>                 break;
>           }
> -      }
> +         strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
> +      } else {
> +         strncpy ( disk_dev_name, dev_name, sizeof ( disk_dev_name) - 1);
> +	  }
>     } else {
>        ret = -LVM_EPV_GET_SIZE_LVM_DIR_CACHE;
>        goto pv_get_size_end;
>     }
> -
> -   memset ( disk_dev_name, 0, sizeof ( disk_dev_name));
> -   strncpy ( disk_dev_name, dir_cache[i].dev_name, sizeof ( disk_dev_name) - 1);
>  
>     first = 1;
>     if ( ( pv_handle = open ( disk_dev_name, O_RDONLY)) == -1) {



-- 

Regards,
Heinz      -- The LVM guy --

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Bartningstr. 12
                                                  64289 Darmstadt
                                                  Germany
Mauelshagen@Sistina.com                           +49 6151 7103 86
                                                       FAX 7103 96
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[Luca Berra]

On Wed, Nov 29, 2000 at 09:59:50PM +0000, Heinz J. Mauelshagen wrote:
> > vgscan will fail in pv_read
> > since pv_read.c contains a line which makes it fail if the device is an
> > me device.
> 
> It's used to distinguish in a higher library layer between MD and other devices.
> 
> > 
> > 0.8.1 has the same line, but pvread s not calle d by vgscan :)
> 
> It gets called indirectly from from vgscan by calling vg_read_with_pv_and_lv().
ok, but 0.8.1 vgscan works with md devices, 0.9 does not,
should i try to patch it at an higher layer then pv_read.c then?

L.

-- 
Luca Berra -- bluca@comedia.it
    Communication Media & Services S.r.l.

Re: [linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[Heinz J. Mauelshagen]

On Fri, Dec 01, 2000 at 02:17:10PM +0100, Luca Berra wrote:
> On Wed, Nov 29, 2000 at 09:59:50PM +0000, Heinz J. Mauelshagen wrote:
> > > vgscan will fail in pv_read
> > > since pv_read.c contains a line which makes it fail if the device is an
> > > me device.
> > 
> > It's used to distinguish in a higher library layer between MD and other devices.
> > 
> > > 
> > > 0.8.1 has the same line, but pvread s not calle d by vgscan :)
> > 
> > It gets called indirectly from from vgscan by calling vg_read_with_pv_and_lv().
> ok, but 0.8.1 vgscan works with md devices, 0.9 does not,
> should i try to patch it at an higher layer then pv_read.c then?
> 

Please help us by narrowing the problem down.

> L.
> 
> -- 
> Luca Berra -- bluca@comedia.it
>     Communication Media & Services S.r.l.
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm

-- 

Regards,
Heinz      -- The LVM guy --

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Bartningstr. 12
                                                  64289 Darmstadt
                                                  Germany
Mauelshagen@Sistina.com                           +49 6151 7103 86
                                                       FAX 7103 96
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-lvm] Old problem cropping up again with 0.9 lvm tools?

[Heinz J. Mauelshagen]

Looks like the 0.8.1 works with MD, 0.9 doesn't.
I asked Luca Bera to help narrowing this one down.

On Tue, Nov 28, 2000 at 07:51:47PM -0800, John DeFranco wrote:
> Hi,
> 
> I'm having a problem doing a pvcreate on a raid
> device. It fails with:
> 
> [root@ham 0.9]# pvcreate -v /dev/md0
> pvcreate -- locking logical volume manager
> pvcreate -- checking physical volume name "/dev/md0"
> pvcreate -- getting physical volume size
> pvcreate -- checking partition type
> pvcreate -- invalid partition type 0x83 for "/dev/md0" (must
> be 0x8e)
> 
> I had this problem with the 0.8final but was pointed to
> a suse lvm user tools rpm (lvm-0.8-70-i386.rpm) that worked
> great. 
> 
> Now with the 0.9 tools the issue is here again. Is there
> a fix for this (since I don't think I should use the
> 0.8 suse tools with 0.9 lvm)?
> 
> Thanks.
> -- 
> ==========
> Cheers
>    -jdf
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm

-- 

Regards,
Heinz      -- The LVM guy --

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Bartningstr. 12
                                                  64289 Darmstadt
                                                  Germany
Mauelshagen@Sistina.com                           +49 6151 7103 86
                                                       FAX 7103 96
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-