* Error in set_cp0_ functions
@ 2001-03-12 17:51 Dan Aizenstros
2001-03-12 19:43 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Dan Aizenstros @ 2001-03-12 17:51 UTC (permalink / raw)
To: linux-mips@oss.sgi.com
Hello All,
There appears to be an error in the new set_cp0_ functions in
the mipsregs.h file.
#define __BUILD_SET_CP0(name,register) \
extern __inline__ unsigned int \
set_cp0_##name(unsigned int set) \
{ \
unsigned int res; \
\
res = read_32bit_cp0_register(register); \
res |= ~set; \
write_32bit_cp0_register(register, res); \
\
return res; \
} \
The line
res |= ~set;
will set every bit except the bit you want to set.
It should be changed to
res |= set;
Also in the mipsregs.h file the line
#define ST0_UM <1 << 4)
should probably be
#define ST0_UM (1 << 4)
I hope this helps.
Dan Aizenstros
Software Engineer
V3 Semiconductor Corp.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Error in set_cp0_ functions
2001-03-12 17:51 Error in set_cp0_ functions Dan Aizenstros
@ 2001-03-12 19:43 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2001-03-12 19:43 UTC (permalink / raw)
To: Dan Aizenstros; +Cc: linux-mips@oss.sgi.com
On Mon, Mar 12, 2001 at 12:51:53PM -0500, Dan Aizenstros wrote:
> There appears to be an error in the new set_cp0_ functions in
> the mipsregs.h file.
Thanks for the report, fixed.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-03-12 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-03-12 17:51 Error in set_cp0_ functions Dan Aizenstros
2001-03-12 19:43 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.