Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later

Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later

[Jeff Garzik]

On Tue, 20 Mar 2001, Alessandro Suardi wrote:
> Jeff Garzik wrote:
> > Neither.  serial.c does serial_cb's job now.  It looks like serial.c
> > needs to scan for modems as well as serial ports, and tytso agrees with
> > me on that.  We just need to check and see if winmodems reports
> > themselves as real modems before fixing this.

> OK, thanks. I assume you mean "serial.c should do serial_cb's job now",
>  since it doesn't :) If you want me to test patches etc. just let me know.

Re-CC'd to linux-kernel, hope you don't mind.

Anyone interested in testing patches, this simple change is what needs
testing on various PCI and CardBus modems:
http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg34097.html
(since it's a web archive, you may have to hack the patch in manually...)

It seems straightforward enough, and both tytso and I think the change
is ok, but (at tytso's suggestion) I'm going to test some various
winmodem and other use cases because assuring ourselves that it is good
enough for a general rule...

Regards,

	Jeff

Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later

[Alessandro Suardi]

Jeff Garzik wrote:
> 
> On Tue, 20 Mar 2001, Alessandro Suardi wrote:
> > Jeff Garzik wrote:
> > > Neither.  serial.c does serial_cb's job now.  It looks like serial.c
> > > needs to scan for modems as well as serial ports, and tytso agrees with
> > > me on that.  We just need to check and see if winmodems reports
> > > themselves as real modems before fixing this.
> 
> > OK, thanks. I assume you mean "serial.c should do serial_cb's job now",
> >  since it doesn't :) If you want me to test patches etc. just let me know.
> 
> Re-CC'd to linux-kernel, hope you don't mind.

No problem for me, of course.

> Anyone interested in testing patches, this simple change is what needs
> testing on various PCI and CardBus modems:
> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg34097.html
> (since it's a web archive, you may have to hack the patch in manually...)

I performed this hand-diff...

[asuardi@princess char]$ diff serial.c serial.c-2.4.3p4 
4613,4614c4613
< 	if (!((dev->class >> 8) == PCI_CLASS_COMMUNICATION_SERIAL ||
< 			(dev->class >> 8) == PCI_CLASS_COMMUNICATION_MODEM) ||
---
> 	if ((dev->class >> 8) != PCI_CLASS_COMMUNICATION_SERIAL ||

...and still my Xircom modem tty isn't detected :(

> It seems straightforward enough, and both tytso and I think the change
> is ok, but (at tytso's suggestion) I'm going to test some various
> winmodem and other use cases because assuring ourselves that it is good
> enough for a general rule...

Available for further testing (or fixing my diff if I patched it badly).


Thanks & ciao,

--alessandro      <alessandro.suardi@oracle.com> <asuardi@uninetcom.it>

Linux:  kernel 2.2.19p17/2.4.3p4 glibc-2.2 gcc-2.96-69 binutils-2.11.90.0.1
Oracle: Oracle8i 8.1.7.0.1 Enterprise Edition for Linux
motto:  Tell the truth, there's less to remember.

[PATCH] Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later

[Jeff Garzik]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On closer inspection, that patch I linked to appears to be incomplete.

Can you try the attached patch, to see if it fixes the
absence-of-serial_cb problem?

Thanks,

	Jeff


P.S. I'm surprised serial_cb in 2.4 worked at all, for anybody.  I guess
they must be using pcmcia_cs's serial_cb, not the kernel's serial_cb...

-- 
Jeff Garzik       | May you have warm words on a cold evening,
Building 1024     | a full mooon on a dark night,
MandrakeSoft      | and a smooth road all the way to your door.

[-- Attachment #2: serial-modem.patch --]
[-- Type: text/plain, Size: 1261 bytes --]

Index: drivers/char/serial.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/char/serial.c,v
retrieving revision 1.1.1.33
diff -u -r1.1.1.33 serial.c
--- drivers/char/serial.c	2001/03/20 12:59:44	1.1.1.33
+++ drivers/char/serial.c	2001/03/20 15:35:47
@@ -59,8 +59,8 @@
  *
  */
 
-static char *serial_version = "5.05";
-static char *serial_revdate = "2000-12-13";
+static char *serial_version = "5.05a";
+static char *serial_revdate = "2001-03-20";
 
 /*
  * Serial driver configuration section.  Here are the various options:
@@ -4610,7 +4610,8 @@
 	 * (Should we try to make guesses for multiport serial devices
 	 * later?) 
 	 */
-	if ((dev->class >> 8) != PCI_CLASS_COMMUNICATION_SERIAL ||
+	if ((((dev->class >> 8) != PCI_CLASS_COMMUNICATION_SERIAL) &&
+	    ((dev->class >> 8) != PCI_CLASS_COMMUNICATION_MODEM)) ||
 	    (dev->class & 0xff) > 6)
 		return 1;
 
@@ -4708,6 +4709,8 @@
 static struct pci_device_id serial_pci_tbl[] __devinitdata = {
        { PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
 	 PCI_CLASS_COMMUNICATION_SERIAL << 8, 0xffff00, },
+       { PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
+	 PCI_CLASS_COMMUNICATION_MODEM << 8, 0xffff00, },
        { 0, }
 };
 

Re: [PATCH] Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later

[Miles Lane]

On 20 Mar 2001 10:37:40 -0500, Jeff Garzik wrote:
> On closer inspection, that patch I linked to appears to be incomplete.
> 
> Can you try the attached patch, to see if it fixes the
> absence-of-serial_cb problem?
> 
> Thanks,
> 
>       Jeff
> 
> 
> P.S. I'm surprised serial_cb in 2.4 worked at all, for anybody.  I guess
> they must be using pcmcia_cs's serial_cb, not the kernel's serial_cb...


Yes.  Well, this just strengthens the case for getting PCMCIA support
migrated fully into the kernel tree so that we can pry people's finger
loose from pcmcia_cs.  David Woodhouse is planning to take up this
project early in the 2.5 development cycle.

It's kind of a shame that more testing of the 2.4.x Cardbus/PCMCIA 
drivers isn't happening, because a lot of the Cardbus/PCMCIA support
in the kernel tree is really just fine.  We should all be using it and
testing it and reporting bugs.

One of the work items will be getting the in-kernel PCMCIA support
to work with the new hotplug stuff.


    Miles