All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH] pcnet32 compilation fix for 2.4.3pre6
Date: Thu, 22 Mar 2001 08:40:11 -0500	[thread overview]
Message-ID: <3ABA00BB.A9C2DF1B@mandrakesoft.com> (raw)
In-Reply-To: <200103220638.HAA16050@green.mif.pg.gda.pl>

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

hmm, on second thought, I think I would prefer the attached patch
(compiled but not tested).

Hardware usually returns all 1's when it's not present, or not working,
so think checking for addresses filled with 1's is a good idea too.

I also took the patch from alan's tree and made the memcmp against
six-byte 'zaddr' rather than a seven-byte string :)

-- 
Jeff Garzik       | May you have warm words on a cold evening,
Building 1024     | a full mooon on a dark night,
MandrakeSoft      | and a smooth road all the way to your door.

[-- Attachment #2: etherdev.patch --]
[-- Type: text/plain, Size: 1037 bytes --]

Index: include/linux/etherdevice.h
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/include/linux/etherdevice.h,v
retrieving revision 1.1.1.14.4.2
diff -u -r1.1.1.14.4.2 etherdevice.h
--- include/linux/etherdevice.h	2001/03/21 14:10:50	1.1.1.14.4.2
+++ include/linux/etherdevice.h	2001/03/22 13:37:15
@@ -46,6 +46,25 @@
 	memcpy (dest->data, src, len);
 }
 
+/**
+ * is_valid_ether_addr - Determine if the given Ethernet address is valid
+ * @addr: Pointer to a six-byte array containing the Ethernet address
+ *
+ * Check that the Ethernet address (MAC) is not 00:00:00:00:00:00, is not
+ * a multicast address, and is not FF:FF:FF:FF:FF:FF.
+ *
+ * Return true if the address is valid.
+ */
+static inline int is_valid_ether_addr( u8 *addr )
+{
+	const char zaddr[6] = {0,};
+	const char faddr[6] = {0xFF,0xFF,0xFF,0xFF,0xFF,0xFF};
+
+	return !(addr[0]&1) &&
+	       memcmp( addr, zaddr, 6) &&
+	       memcmp( addr, faddr, 6);
+}
+
 #endif
 
 #endif	/* _LINUX_ETHERDEVICE_H */

  parent reply	other threads:[~2001-03-22 13:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-22  6:38 [PATCH] pcnet32 compilation fix for 2.4.3pre6 Andrzej Krzysztofowicz
2001-03-22 10:43 ` Jeff Garzik
2001-03-22 13:40 ` Jeff Garzik [this message]
2001-03-22 14:39   ` Eli Carter
2001-03-22 14:46     ` Jeff Garzik
2001-03-22 15:10       ` Eli Carter
2001-03-22 16:23         ` Jeff Garzik
2001-03-29 21:09         ` dank
2001-03-29 21:25           ` Ulrich Drepper
2001-03-29 21:29             ` Eli Carter
2001-03-29 22:55             ` Tom Leete
2001-03-30  9:36               ` Jeff Garzik
2001-03-22 14:49   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ABA00BB.A9C2DF1B@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ankry@green.mif.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.