From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Eli Carter <eli.carter@inet.com>
Cc: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>,
Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pcnet32 compilation fix for 2.4.3pre6
Date: Thu, 22 Mar 2001 11:23:53 -0500 [thread overview]
Message-ID: <3ABA2719.C09F835E@mandrakesoft.com> (raw)
In-Reply-To: <200103220638.HAA16050@green.mif.pg.gda.pl> <3ABA00BB.A9C2DF1B@mandrakesoft.com> <3ABA0E89.D3D965B7@inet.com> <3ABA103A.CB07012D@mandrakesoft.com> <3ABA15F7.6155F0EE@inet.com>
Eli Carter wrote:
> Mmmm.... documentation. Yummy. ;)
>
> When I submitted the original patch, someone wanted to add the ff's
> check as well... to reduce the number of people who make that
> suggestion, perhaps the comment should read:
>
> + * Check that the Ethernet address (MAC) is not a multicast address or
> + * FF:FF:FF:FF:FF:FF (by checking addr[0]&1) and is not
> 00:00:00:00:00:00.
> + *
>
> Does that make it clear that both cases are covered by the one test?
yeah
> Hmm... I used __inline__ because the other function in the same
> headerfile used it... What is the difference between the two, and is
> one depricated now? (And what about in 2.2.x?)
since kernel requires gcc, which supports plaine ole 'inline', we don't
need to use the longer form.
--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full mooon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.
next prev parent reply other threads:[~2001-03-22 16:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-22 6:38 [PATCH] pcnet32 compilation fix for 2.4.3pre6 Andrzej Krzysztofowicz
2001-03-22 10:43 ` Jeff Garzik
2001-03-22 13:40 ` Jeff Garzik
2001-03-22 14:39 ` Eli Carter
2001-03-22 14:46 ` Jeff Garzik
2001-03-22 15:10 ` Eli Carter
2001-03-22 16:23 ` Jeff Garzik [this message]
2001-03-29 21:09 ` dank
2001-03-29 21:25 ` Ulrich Drepper
2001-03-29 21:29 ` Eli Carter
2001-03-29 22:55 ` Tom Leete
2001-03-30 9:36 ` Jeff Garzik
2001-03-22 14:49 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ABA2719.C09F835E@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ankry@green.mif.pg.gda.pl \
--cc=eli.carter@inet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.