From: Dan Malek <dan@mvista.com>
To: David Schleef <ds@schleef.org>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: bugfix patch to arch/ppc/8260_io/fcc_enet.c
Date: Mon, 09 Apr 2001 13:57:04 -0400 [thread overview]
Message-ID: <3AD1F7F0.23C8BA38@mvista.com> (raw)
In-Reply-To: 20010408152817.A5105@stm.lbl.gov
David Schleef wrote:
> Check again. The unsigned arithmetic works correctly.
OK.
> (starting with a full queue)
This one can't happen because of the race conditions are avoided
by the use of cep->lock.
> The other (and more likely) is:
>
> - fcc_enet_start_xmit() fills up the TX ring, thus cep->skb_cur
> == cep->skb->dirty.
What driver are you using? That line of code hasn't been in a driver
for a very long time. This was a very obvious bug that has been
corrected long ago. You should be using the FSM Labs linuxppc_2_5
bitkeeper tree for any of the 8xx/82xx development. There are lots
of things that were placed in the 2_5 tree when the 2.4 tree was frozen.
We are now trying to merge them back, but there are still some pieces
left to go.
-- Dan
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2001-04-09 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-06 14:16 bugfix patch to arch/ppc/8260_io/fcc_enet.c David Schleef
2001-04-08 7:15 ` Dan Malek
2001-04-08 22:28 ` David Schleef
2001-04-09 17:57 ` Dan Malek [this message]
2001-04-09 20:10 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AD1F7F0.23C8BA38@mvista.com \
--to=dan@mvista.com \
--cc=ds@schleef.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.