From: Dan Malek <dan@mvista.com>
To: David Schleef <ds@schleef.org>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: bugfix patch to arch/ppc/8260_io/fcc_enet.c
Date: Mon, 09 Apr 2001 16:10:56 -0400 [thread overview]
Message-ID: <3AD21750.173DEEE6@mvista.com> (raw)
In-Reply-To: 20010408152817.A5105@stm.lbl.gov
David Schleef wrote:
> The other (and more likely) is:
> if(cep->skb_cur == cep->skb_dirty)break;
OK, I kind of found this too. My last message indicated this
should have been fixed, and if this _exact_ line of code is in
your driver, it is too old. The proper test checks for the buffer
pointers equal, and also adds the 'tx_full' condition so the
wrap around case is properly handled.
The current version of this driver has been subjected to the
University of New Hampshire Interoperability testing lab by
a very large communication company. The test reports were sent
to me, I made some changes according to their recommendations,
and I believe they were happy with the results. I would hope
they found all of the errors :-).
-- Dan
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2001-04-09 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-06 14:16 bugfix patch to arch/ppc/8260_io/fcc_enet.c David Schleef
2001-04-08 7:15 ` Dan Malek
2001-04-08 22:28 ` David Schleef
2001-04-09 17:57 ` Dan Malek
2001-04-09 20:10 ` Dan Malek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AD21750.173DEEE6@mvista.com \
--to=dan@mvista.com \
--cc=ds@schleef.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.