[PATCH] Remove silly beep macro from pgtable.h

[PATCH] Remove silly beep macro from pgtable.h

[Jeff Golds]

Hi folks,

Found this bit of unused code in the i386 and sh architectures.  As it's not being used, let's get rid of it.  Also, pgtable.h seems to be an odd place for this.

-Jeff

diff -u -r linux-2.4.4.pure/include/asm-i386/pgtable.h linux-2.4.4/include/asm-i386/pgtable.h
--- linux-2.4.4.pure/include/asm-i386/pgtable.h Fri Apr 27 15:48:21 2001
+++ linux-2.4.4/include/asm-i386/pgtable.h      Tue May 15 09:12:24 2001
@@ -110,8 +110,6 @@
 #endif
 #endif

-#define __beep() asm("movb $0x3,%al; outb %al,$0x61")
-
 #define PMD_SIZE       (1UL << PMD_SHIFT)
 #define PMD_MASK       (~(PMD_SIZE-1))
 #define PGDIR_SIZE     (1UL << PGDIR_SHIFT)
diff -u -r linux-2.4.4.pure/include/asm-sh/pgtable.h linux-2.4.4/include/asm-sh/pgtable.h
--- linux-2.4.4.pure/include/asm-sh/pgtable.h   Wed Apr 11 21:24:52 2001
+++ linux-2.4.4/include/asm-sh/pgtable.h        Tue May 15 09:35:29 2001
@@ -72,8 +72,6 @@

 #include <asm/pgtable-2level.h>

-#define __beep() asm("")
-
 #define PMD_SIZE       (1UL << PMD_SHIFT)
 #define PMD_MASK       (~(PMD_SIZE-1))
 #define PGDIR_SIZE     (1UL << PGDIR_SHIFT)

-- 
Jeff Golds
jgolds@resilience.com

Re: [PATCH] Remove silly beep macro from pgtable.h

[Mike Galbraith]

On Tue, 15 May 2001, Jeff Golds wrote:

> Hi folks,
>
> Found this bit of unused code in the i386 and sh architectures.  As it's not being used, let's get rid of it.  Also, pgtable.h seems to be an odd place for this.

I'd leave it.. folks with early boot troubles might find it useful.

	-Mike

Re: [PATCH] Remove silly beep macro from pgtable.h

[Jonathan Lundell]

At 7:36 PM +0200 2001-05-15, Mike Galbraith wrote:
>On Tue, 15 May 2001, Jeff Golds wrote:
>
>>  Hi folks,
>>
>>  Found this bit of unused code in the i386 and sh architectures. 
>>As it's not being used, let's get rid of it.  Also, pgtable.h seems 
>>to be an odd place for this.
>
>I'd leave it.. folks with early boot troubles might find it useful.
>
>	-Mike

Consider small rant about literal IO references to magic locations 
hereby ranted. Especially in header files completely unrelated to the 
IO function in question.

-#define __beep() asm("movb $0x3,%al; outb %al,$0x61")

Let's please not assume that every i386 implementation has a full set 
of legacy PC IO hardware.
-- 
/Jonathan Lundell.

Re: [PATCH] Remove silly beep macro from pgtable.h

[Mike Galbraith]

On Tue, 15 May 2001, Jonathan Lundell wrote:

> At 7:36 PM +0200 2001-05-15, Mike Galbraith wrote:
> >On Tue, 15 May 2001, Jeff Golds wrote:
> >
> >>  Hi folks,
> >>
> >>  Found this bit of unused code in the i386 and sh architectures.
> >>As it's not being used, let's get rid of it.  Also, pgtable.h seems
> >>to be an odd place for this.
> >
> >I'd leave it.. folks with early boot troubles might find it useful.
> >
> >	-Mike
>
> Consider small rant about literal IO references to magic locations
> hereby ranted. Especially in header files completely unrelated to the
> IO function in question.
>
> -#define __beep() asm("movb $0x3,%al; outb %al,$0x61")
>
> Let's please not assume that every i386 implementation has a full set
> of legacy PC IO hardware.

Is there a generic form of hello() that could be tucked away somewhere?

	-Mike