* EEPro100 bug in 2.4.6pre5
@ 2001-06-27 16:15 Alan Cox
2001-06-27 18:09 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2001-06-27 16:15 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
Looking over the merges Im doing from 2.4.6pre I found a couple of suprises
the most dubious of which is the rather bogus hackery on eepro100.c
Someone has done S/CONFIG_EEPRO100_PM/CONFIG_PM/ on the driver and in doing
so permanently enabled the eepro100 pm code which to say the least doesnt work
for a lot of people but gives them weird eepro100 hangs
Since the drivers/net/Config option wasnt removed I can only conclude this was
someones internal hack that leaked out in error
Linus - I think you need to revert that eepro100 change.
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: EEPro100 bug in 2.4.6pre5
2001-06-27 16:15 EEPro100 bug in 2.4.6pre5 Alan Cox
@ 2001-06-27 18:09 ` Jeff Garzik
2001-06-27 18:12 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2001-06-27 18:09 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, torvalds
Alan Cox wrote:
> Someone has done S/CONFIG_EEPRO100_PM/CONFIG_PM/ on the driver and in doing
> so permanently enabled the eepro100 pm code which to say the least doesnt work
> for a lot of people but gives them weird eepro100 hangs
Do you have a bug report of this actually breaking?
eepro100 is doing standard PCI PM. The only reason AFAICS why it was
breaking for people was that the previous PCI PM code did not do all the
stuff it needed to do. PCI PM should cover the various cases correctly,
now, ditto eepro100.
--
Jeff Garzik | Andre the Giant has a posse.
Building 1024 |
MandrakeSoft |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: EEPro100 bug in 2.4.6pre5
2001-06-27 18:09 ` Jeff Garzik
@ 2001-06-27 18:12 ` Alan Cox
0 siblings, 0 replies; 3+ messages in thread
From: Alan Cox @ 2001-06-27 18:12 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Alan Cox, linux-kernel, torvalds
> Do you have a bug report of this actually breaking?
I've not been able to make 2.4.6pre5 stay up long enough to do any real
testing on this. It just keeps hanging all the time anyway
> eepro100 is doing standard PCI PM. The only reason AFAICS why it was
> breaking for people was that the previous PCI PM code did not do all the
> stuff it needed to do. PCI PM should cover the various cases correctly,
> now, ditto eepro100.
The they should fix Config.in
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-06-27 18:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-06-27 16:15 EEPro100 bug in 2.4.6pre5 Alan Cox
2001-06-27 18:09 ` Jeff Garzik
2001-06-27 18:12 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.