All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] 2.4.16: 802.1Q VLAN non-modular
@ 2001-11-26 16:03 Maciej W. Rozycki
  2001-11-26 16:35 ` Rik van Riel
  2001-11-27  1:55 ` Ben Greear
  0 siblings, 2 replies; 10+ messages in thread
From: Maciej W. Rozycki @ 2001-11-26 16:03 UTC (permalink / raw)
  To: Ben Greear, Ben Greear, Alan Cox, Marcelo Tosatti; +Cc: linux-kernel

Hi,

 It appears the 802.1Q VLAN support didn't receive even basic testing,
sigh...  It doesn't compile non-modular, due to vlan_proc_cleanup() being
discarded, yet needed in vlan_proc_init().  Following is a fix. 

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

patch-mips-2.4.14-20011123-vlan-0
diff -up --recursive --new-file linux-mips-2.4.14-20011123.macro/net/8021q/vlanproc.c linux-mips-2.4.14-20011123/net/8021q/vlanproc.c
--- linux-mips-2.4.14-20011123.macro/net/8021q/vlanproc.c	Tue Nov  6 07:56:16 2001
+++ linux-mips-2.4.14-20011123/net/8021q/vlanproc.c	Sun Nov 25 02:28:24 2001
@@ -116,7 +116,7 @@ static char conf_hdr[] = "VLAN Dev name	
  *	Clean up /proc/net/vlan entries
  */
 
-void __exit vlan_proc_cleanup(void)
+void vlan_proc_cleanup(void)
 {
 	if (proc_vlan_conf)
 		remove_proc_entry(name_conf, proc_vlan_dir);
@@ -462,7 +462,7 @@ int __init vlan_proc_init (void)
 	return 0;
 }
 
-void __exit vlan_proc_cleanup(void)
+void vlan_proc_cleanup(void)
 {
 	return;
 }


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [patch] 2.4.16: 802.1Q VLAN non-modular
@ 2001-11-27  7:55 willy tarreau
  0 siblings, 0 replies; 10+ messages in thread
From: willy tarreau @ 2001-11-27  7:55 UTC (permalink / raw)
  To: Ben Greear; +Cc: linux-kernel

> By the way, I just successfully compiled 2.4.16
(including
> VLAN builtin) with no problems.  It looks like
Maciej is
> compiling MIPS, so it may be a bug particular to
that
> platform?? 

Ben, you remember the patch I sent to you a few weeks
ago ?
VLAN didn't link builtin on alpha because
vlan_proc_cleanup()
in section __exit was called from vlan_proc_init() in
section
__init, and it semt that the absolute offsets between
these
two functions were too big for the linker to put it on
a 16 bit
value (which was the space reserved for a relative
call, it 
seems). So the linker complained and stopped. I had to
extract
the cleanup from __exit and put it into another
function which
worked.

Regards,
Willy


___________________________________________________________
Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français !
Yahoo! Courrier : http://courrier.yahoo.fr

^ permalink raw reply	[flat|nested] 10+ messages in thread
[parent not found: <fa.ns5og9v.u04srk@ifi.uio.no>]

end of thread, other threads:[~2001-11-27 11:52 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-11-26 16:03 [patch] 2.4.16: 802.1Q VLAN non-modular Maciej W. Rozycki
2001-11-26 16:35 ` Rik van Riel
2001-11-27  2:24   ` Keith Owens
2001-11-27  3:37     ` Ben Greear
2001-11-27 11:50       ` Maciej W. Rozycki
2001-11-27  9:36   ` Chris Wedgwood
2001-11-27  1:55 ` Ben Greear
  -- strict thread matches above, loose matches on Subject: below --
2001-11-27  7:55 willy tarreau
     [not found] <fa.ns5og9v.u04srk@ifi.uio.no>
     [not found] ` <fa.hfatgnv.q50k9n@ifi.uio.no>
2001-11-27  8:32   ` Giacomo Catenazzi
2001-11-27  8:59     ` Keith Owens

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.