From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Tim Hockin <thockin@sun.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Rx FIFO Overrun error found
Date: Sun, 13 Jan 2002 19:54:49 -0500 [thread overview]
Message-ID: <3C422C59.90E7D5CB@mandrakesoft.com> (raw)
In-Reply-To: <3C40A6F2.18A8C3E6@colorfullife.com>
Manfred Spraul wrote:
>
> Hi all,
>
> I think I found the reason for the Rx status FIFO overrun nic hang:
> If the Rx fifo overflows, the nic sets RxStatusFIFOOver _instead_ of
> IntrRxIntr.
> Thus netdev_rx is never called, the rx ring is never refilled, nic
> hangs.
>
> The attached patch adds proper OOM handling to natsemi.c.
> I've also copied the simpler netdev_close locking from ns83820.c.
Two comments, sis900.c uses the check (rx-overrun | rx-err | rx-ok), did
you test that combination? (s/RxStatusFIFOOver/IntrRxOverrun/)
and it would be preferred to separate "add oom handling" and "fix nic
hang" patches.
--
Jeff Garzik | Alternate titles for LOTR:
Building 1024 | Fast Times at Uruk-Hai
MandrakeSoft | The Took, the Elf, His Daughter and Her Lover
| Samwise Gamgee: International Hobbit of Mystery
next prev parent reply other threads:[~2002-01-14 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-12 21:13 [PATCH] Rx FIFO Overrun error found Manfred Spraul
2002-01-12 21:11 ` Tim Hockin
2002-01-12 21:57 ` Manfred Spraul
2002-01-14 0:54 ` Jeff Garzik [this message]
2002-01-14 16:32 ` Manfred Spraul
2002-02-08 10:38 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2002-01-14 18:52 Torrey Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C422C59.90E7D5CB@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=thockin@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.