All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Tim Hockin <thockin@sun.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Rx FIFO Overrun error found
Date: Mon, 14 Jan 2002 17:32:02 +0100	[thread overview]
Message-ID: <3C430802.8B8A273E@colorfullife.com> (raw)
In-Reply-To: <3C40A6F2.18A8C3E6@colorfullife.com> <3C422C59.90E7D5CB@mandrakesoft.com>

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Jeff Garzik wrote:
> 
> and it would be preferred to separate "add oom handling" and "fix nic
> hang" patches.
>
Attached is the patch against the nic hang. Now all rx error bits
trigger netdev_rx - it doesn't hurt and could catch further hardware
oddities.

--
	Manfred

[-- Attachment #2: patch-natsemi-fifoonly --]
[-- Type: text/plain, Size: 418 bytes --]

--- 2.5/drivers/net/natsemi.c	Fri Nov 23 20:35:23 2001
+++ build-2.5/drivers/net/natsemi.c	Mon Jan 14 16:56:22 2002
@@ -1508,7 +1508,7 @@
 		if (intr_status == 0)
 			break;
 
-		if (intr_status & (IntrRxDone | IntrRxIntr))
+		if (intr_status & (IntrRxDone | IntrRxIntr | RxStatusFIFOOver | IntrRxErr | IntrRxOverrun ))
 			netdev_rx(dev);
 
 		if (intr_status & (IntrTxDone | IntrTxIntr | IntrTxIdle | IntrTxErr) ) {

  reply	other threads:[~2002-01-14 17:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-12 21:13 [PATCH] Rx FIFO Overrun error found Manfred Spraul
2002-01-12 21:11 ` Tim Hockin
2002-01-12 21:57   ` Manfred Spraul
2002-01-14  0:54 ` Jeff Garzik
2002-01-14 16:32   ` Manfred Spraul [this message]
2002-02-08 10:38     ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2002-01-14 18:52 Torrey Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C430802.8B8A273E@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thockin@sun.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.