* [PATCH] 2.5.4pre5 scsi/aha1542.c & DMA changes
@ 2002-02-09 14:48 Paul Gortmaker
0 siblings, 0 replies; only message in thread
From: Paul Gortmaker @ 2002-02-09 14:48 UTC (permalink / raw)
To: torvalds, davem; +Cc: linux-kernel
There are a couple of errors in the DMA changes to the
aha1542.c driver that appeared in 2.5.4pre3:
- a typo (BUF vs BUS)
- a macro handed a page instead of a scatterlist
- printk format length mismatch
Paul.
--- drivers/scsi/aha1542.c~ Fri Feb 8 06:38:42 2002
+++ drivers/scsi/aha1542.c Sat Feb 9 09:36:48 2002
@@ -58,7 +58,7 @@
{
printk(KERN_CRIT "buf vaddress %p paddress 0x%lx length %d\n",
address,
- SCSI_BUS_PA(address),
+ SCSI_BUF_PA(address),
length);
panic("Buffer at physical address > 16Mb used for aha1542");
}
@@ -68,7 +68,7 @@
int nseg,
int badseg)
{
- printk(KERN_CRIT "sgpnt[%d:%d] page %p/0x%lx length %d\n",
+ printk(KERN_CRIT "sgpnt[%d:%d] page %p/0x%x length %d\n",
badseg, nseg,
page_address(sgpnt[badseg].page) + sgpnt[badseg].offset,
SCSI_SG_PA(&sgpnt[badseg]),
@@ -727,7 +727,7 @@
panic("Foooooooood fight!");
};
any2scsi(cptr[i].dataptr, SCSI_SG_PA(&sgpnt[i]));
- if (SCSI_SG_PA(&sgpnt[i].page) + sgpnt[i].length - 1 > ISA_DMA_THRESHOLD)
+ if (SCSI_SG_PA(&sgpnt[i]) + sgpnt[i].length - 1 > ISA_DMA_THRESHOLD)
BAD_SG_DMA(SCpnt, sgpnt, SCpnt->use_sg, i);
any2scsi(cptr[i].datalen, sgpnt[i].length);
};
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-02-09 14:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-02-09 14:48 [PATCH] 2.5.4pre5 scsi/aha1542.c & DMA changes Paul Gortmaker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.