All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Dalecki <dalecki@evision-ventures.com>
To: unlisted-recipients:; (no To-header on input)@localhost.localdomain
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	John Langford <jcl@cs.cmu.edu>,
	linux-kernel@vger.kernel.org
Subject: Re: BUG: 2.4.18 & ALI15X3 DMA hang on boot
Date: Fri, 22 Mar 2002 12:50:11 +0100	[thread overview]
Message-ID: <3C9B1A73.2070606@evision-ventures.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10203220309400.10409-100000@master.linux-ide.org>

Andre Hedrick wrote:
> Martin,
> 
> You go and play in 2.5, please.

I didn't look at the issue but anyway the following is still
obviously wrong. hwif->index should be hwif->channel

Anyway please note the following:

diff -urN linux-2.5.7/drivers/ide/alim15x3.c linux/drivers/ide/alim15x3.c
--- linux-2.5.7/drivers/ide/alim15x3.c	Thu Mar 21 23:54:16 2002
+++ linux/drivers/ide/alim15x3.c	Fri Mar 22 02:08:58 2002
@@ -247,8 +247,8 @@
  	int s_time, a_time, c_time;
  	byte s_clc, a_clc, r_clc;
  	unsigned long flags;
	int port = hwif->index ? 0x5c : 0x58;
	int portFIFO = hwif->channel ? 0x55 : 0x54;

The usage of hwif->index *is* wrong.



  reply	other threads:[~2002-03-22 11:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-21 20:47 BUG: 2.4.18 & ALI15X3 DMA hang on boot John Langford
2002-03-21 22:17 ` Alan Cox
2002-03-21 22:41   ` John Langford
2002-03-22  0:47   ` Dave Zarzycki
2002-03-22  1:43     ` John Langford
2002-03-22 20:46     ` John Langford
2002-03-23 13:25       ` Martin Dalecki
2002-03-23 14:19         ` John Langford
2002-03-23 14:22           ` Martin Dalecki
2002-03-23 14:51             ` Art Haas
2002-03-23 19:49             ` Dave Zarzycki
2002-03-24 22:47               ` Martin Dalecki
2002-03-22 10:55   ` Martin Dalecki
2002-03-22 11:24     ` Andre Hedrick
2002-03-22 11:50       ` Martin Dalecki [this message]
2002-03-22 15:59         ` John Langford
2002-03-23  5:16         ` Andre Hedrick
2002-03-23 13:05           ` Martin Dalecki
2002-03-25  2:26             ` Andre Hedrick
2002-03-22 13:25       ` Jens Axboe
2002-03-22 14:49       ` Alan Cox
2002-03-22 20:53         ` Andre Hedrick
2002-03-22 21:52           ` Andre Hedrick
2002-03-23  3:51           ` Ian Molton
2002-03-23  3:57             ` Ian Molton
2002-03-22 19:56     ` John Langford
2002-03-22 21:53       ` Vojtech Pavlik
2002-03-23 13:11       ` Martin Dalecki
2002-03-23 13:43         ` Jeff Garzik
2002-03-23 13:47           ` Martin Dalecki
2002-03-23 20:23         ` Vojtech Pavlik
2002-03-23 21:43         ` Andre Hedrick
2002-03-24 22:50           ` Martin Dalecki
2002-03-25  1:26             ` Andre Hedrick
2002-03-25  9:24               ` Vojtech Pavlik
2002-03-25  9:40                 ` Andre Hedrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C9B1A73.2070606@evision-ventures.com \
    --to=dalecki@evision-ventures.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jcl@cs.cmu.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.