HDLC driver for MPC860-based hardware

All of lore.kernel.org
 help / color / mirror / Atom feed

* HDLC driver for MPC860-based hardware
@ 2002-04-22  8:59 Adam Kaczynski
  2002-04-22 11:34 ` Francois Romieu
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Kaczynski @ 2002-04-22  8:59 UTC (permalink / raw)
  To: linux-kernel, linuxppc-announce; +Cc: Adam Kaczynski

Hello,
As a part of the bigger project being developed in DGT-LAB (the NETX), I 
have written a HDLC driver for our proprietary Motorola MPC860T-based 
board. We are not going to integrate this software with the main Linux 
source tree, but this software is released under GPL as a loadable 
module for 2.4.18 Linux kernel. The current version is a mature test 
version.
The sources and documentation are available at:
<http://www.dgt-lab.com.pl/Serwis/mpc860hdlc.tar.gz>
If you have any questions or suggestions please contact me:
<mailto:kaczor@dgt-lab.com.pl>
Adam Kaczynski

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: HDLC driver for MPC860-based hardware
  2002-04-22  8:59 HDLC driver for MPC860-based hardware Adam Kaczynski
@ 2002-04-22 11:34 ` Francois Romieu
  0 siblings, 0 replies; 2+ messages in thread
From: Francois Romieu @ 2002-04-22 11:34 UTC (permalink / raw)
  To: Adam Kaczynski; +Cc: linux-kernel, linuxppc-announce

Greetings,

- please, please, please read Documentation/CodingStyle
- kmalloc can fail
- cache seems to be disabled (?) for pages you memcpy later -> why ?
- if register_hdlc_device() fails for some device, the succeeded one are
  deallocated but not unregistered
- alloc_mem() doesn't deallocate on failure
- goto may help handling failure

-- 
Ueimor

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-04-22 11:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-04-22  8:59 HDLC driver for MPC860-based hardware Adam Kaczynski
2002-04-22 11:34 ` Francois Romieu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.