2.5.12: hpt34x.c:259: too few arguments to function `ide_dmaproc'

2.5.12: hpt34x.c:259: too few arguments to function `ide_dmaproc'

[Adrian Bunk]

Just FYI:

The ide_dmaproc changes in 2.5.12 broke the compilation of hpt34x.c (I
tried 2.5.12-dj1 but this shouldn't make a difference):

<--  snip  -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.5/linux-2.5.12/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=k6   -nostdinc -I
/usr/lib/gcc-lib/i386-linux/2.95.4
/include -DKBUILD_BASENAME=hpt34x  -c -o hpt34x.o hpt34x.c
hpt34x.c: In function `config_drive_xfer_rate':
hpt34x.c:259: too few arguments to function `ide_dmaproc'
hpt34x.c:281: too few arguments to function `ide_dmaproc'
hpt34x.c:304: structure has no member named `dmaproc'
hpt34x.c:305: warning: control reaches end of non-void function
hpt34x.c: In function `hpt34x_dmaproc':
hpt34x.c:350: too few arguments to function `ide_dmaproc'
hpt34x.c: In function `ide_init_hpt34x':
hpt34x.c:426: structure has no member named `dmaproc'
make[3]: *** [hpt34x.o] Error 1
make[3]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.12/drivers/ide
'

<--  snip  -->

cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox

Re: 2.5.12: hpt34x.c:259: too few arguments to function `ide_dmaproc'

[Martin Dalecki]

Uz.ytkownik Adrian Bunk napisa?:
> Just FYI:
> 
> The ide_dmaproc changes in 2.5.12 broke the compilation of hpt34x.c (I
> tried 2.5.12-dj1 but this shouldn't make a difference):
> 
> <--  snip  -->
> 
> ...
> gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.5/linux-2.5.12/include -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
> -mpreferred-stack-boundary=2 -march=k6   -nostdinc -I
> /usr/lib/gcc-lib/i386-linux/2.95.4
> /include -DKBUILD_BASENAME=hpt34x  -c -o hpt34x.o hpt34x.c
> hpt34x.c: In function `config_drive_xfer_rate':
> hpt34x.c:259: too few arguments to function `ide_dmaproc'
> hpt34x.c:281: too few arguments to function `ide_dmaproc'
> hpt34x.c:304: structure has no member named `dmaproc'
> hpt34x.c:305: warning: control reaches end of non-void function
> hpt34x.c: In function `hpt34x_dmaproc':
> hpt34x.c:350: too few arguments to function `ide_dmaproc'
> hpt34x.c: In function `ide_init_hpt34x':
> hpt34x.c:426: structure has no member named `dmaproc'
> make[3]: *** [hpt34x.o] Error 1
> make[3]: Leaving directory

Just adding a trailing struct request *rq parameter
to hpt34x_dmaproc() and passing it there to ide_dmaproc
as well as changing dmaproc to udma at line 426 will do.

Re: 2.5.12: hpt34x.c:259: too few arguments to function `ide_dmaproc'

[Martin Dalecki]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

Uz.ytkownik Adrian Bunk napisa?:
> Just FYI:
> 
> The ide_dmaproc changes in 2.5.12 broke the compilation of hpt34x.c (I
> tried 2.5.12-dj1 but this shouldn't make a difference):


The following should do the trick.

[-- Attachment #2: hpt34x.diff --]
[-- Type: text/plain, Size: 2160 bytes --]

diff -ur linux-2.5.12/drivers/ide/hpt34x.c linux/drivers/ide/hpt34x.c
--- linux-2.5.12/drivers/ide/hpt34x.c	2002-05-01 02:08:47.000000000 +0200
+++ linux/drivers/ide/hpt34x.c	2002-05-02 21:28:02.000000000 +0200
@@ -249,14 +249,14 @@
 						     ide_dma_off_quietly);
 }
 
-static int config_drive_xfer_rate (ide_drive_t *drive)
+static int config_drive_xfer_rate(struct ata_device *drive, struct request *rq)
 {
 	struct hd_driveid *id = drive->id;
 	ide_dma_action_t dma_func = ide_dma_on;
 
 	if (id && (id->capability & 1) && drive->channel->autodma) {
 		/* Consult the list of known "bad" drives */
-		if (ide_dmaproc(ide_dma_bad_drive, drive)) {
+		if (ide_dmaproc(ide_dma_bad_drive, drive, rq)) {
 			dma_func = ide_dma_off;
 			goto fast_ata_pio;
 		}
@@ -278,7 +278,7 @@
 				if (dma_func != ide_dma_on)
 					goto no_dma_set;
 			}
-		} else if (ide_dmaproc(ide_dma_good_drive, drive)) {
+		} else if (ide_dmaproc(ide_dma_good_drive, drive, rq)) {
 			if (id->eide_dma_time > 150) {
 				goto no_dma_set;
 			}
@@ -301,7 +301,7 @@
 		dma_func = ide_dma_off;
 #endif /* CONFIG_HPT34X_AUTODMA */
 
-	return drive->channel->dmaproc(dma_func, drive);
+	return drive->channel->udma(dma_func, drive, rq);
 }
 
 /*
@@ -312,7 +312,7 @@
  * by HighPoint|Triones Technologies, Inc.
  */
 
-int hpt34x_dmaproc (ide_dma_action_t func, ide_drive_t *drive)
+int hpt34x_dmaproc (ide_dma_action_t func, struct ata_device *drive, struct request *rq)
 {
 	struct ata_channel *hwif = drive->channel;
 	unsigned long dma_base = hwif->dma_base;
@@ -321,7 +321,7 @@
 
 	switch (func) {
 		case ide_dma_check:
-			return config_drive_xfer_rate(drive);
+			return config_drive_xfer_rate(drive, rq);
 		case ide_dma_read:
 			reading = 1 << 3;
 		case ide_dma_write:
@@ -347,7 +347,7 @@
 		default:
 			break;
 	}
-	return ide_dmaproc(func, drive);	/* use standard DMA stuff */
+	return ide_dmaproc(func, drive, rq);	/* use standard DMA stuff */
 }
 #endif /* CONFIG_BLK_DEV_IDEDMA */
 
@@ -423,7 +423,7 @@
 		else
 			hwif->autodma = 0;
 
-		hwif->dmaproc = &hpt34x_dmaproc;
+		hwif->udma = &hpt34x_dmaproc;
 		hwif->highmem = 1;
 	} else {
 		hwif->drives[0].autotune = 1;

Re: 2.5.12: hpt34x.c:259: too few arguments to function `ide_dmaproc'

[Adrian Bunk]

On Thu, 2 May 2002, Martin Dalecki wrote:

> > Just FYI:
> >
> > The ide_dmaproc changes in 2.5.12 broke the compilation of hpt34x.c (I
> > tried 2.5.12-dj1 but this shouldn't make a difference):
>
>
> The following should do the trick.

Yes, it compiles fine now.

cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox