CONFIG_SND_RTC and CONFIG_SND_RTCTIMER and CONFIG_RTC, oh my!

CONFIG_SND_RTC and CONFIG_SND_RTCTIMER and CONFIG_RTC, oh my!

[Clemens Ladisch]

I tried to use the RTC callback timer with my 2.4.12 kernel.
Patching the kernel went fine, but then ALSA wouldn't compile the
snd-rtctimer.o module, although configure said:
| checking for RTC callback support in kernel ... "yes"

A glance at alsa-kernel/core/Makefile shows that both CONFIG_RTC and
CONFIG_SND_RTCTIMER need to be defined:

	ifeq ($(subst m,y,$(CONFIG_RTC)),y)
	  obj-$(CONFIG_SND_RTCTIMER) += snd-timer.o
	  obj-$(CONFIG_SND_RTCTIMER) += snd-rtctimer.o
	endif

... but neither appears in alsa-driver/Makefile.conf, apparently
because configure thinks it should define CONFIG_SND_RTC instead:

alsa-driver/configure.in:
	...
	rtcsup="0"
	...
	  AC_MSG_RESULT("yes");rtcsup="m",
	  AC_MSG_RESULT("no");rtcsup="n",
	  AC_MSG_RESULT("unknown");rtcsup="n"
	...
	CONFIG_SND_RTC=$rtcsup
	AC_SUBST(CONFIG_SND_RTC)
	if test "$CONFIG_SND_RTC" = "1"; then
	  AC_DEFINE(CONFIG_SND_RTC)
	fi

Additionally, it's unclear whether the value of CONFIG_SND_RTC should
be 0/1 or n/m.


Sorry, no patch because I'm lacking the autoconf knowledge for this.
(I got it to compile (and run) by hacking the makefile, but I won't
submit _this_ change. :-)


Clemens

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: bandwidth@sourceforge.net

Re: CONFIG_SND_RTC and CONFIG_SND_RTCTIMER and CONFIG_RTC, oh my!

[Takashi Iwai]

At Tue, 14 May 2002 10:49:22 +0200,
Clemens Ladisch wrote:
> 
> I tried to use the RTC callback timer with my 2.4.12 kernel.
> Patching the kernel went fine, but then ALSA wouldn't compile the
> snd-rtctimer.o module, although configure said:
> | checking for RTC callback support in kernel ... "yes"
> 
> A glance at alsa-kernel/core/Makefile shows that both CONFIG_RTC and
> CONFIG_SND_RTCTIMER need to be defined:
> 
> 	ifeq ($(subst m,y,$(CONFIG_RTC)),y)
> 	  obj-$(CONFIG_SND_RTCTIMER) += snd-timer.o
> 	  obj-$(CONFIG_SND_RTCTIMER) += snd-rtctimer.o
> 	endif
> 
> ... but neither appears in alsa-driver/Makefile.conf, apparently
> because configure thinks it should define CONFIG_SND_RTC instead:
> 
> alsa-driver/configure.in:
> 	...
> 	rtcsup="0"
> 	...
> 	  AC_MSG_RESULT("yes");rtcsup="m",
> 	  AC_MSG_RESULT("no");rtcsup="n",
> 	  AC_MSG_RESULT("unknown");rtcsup="n"
> 	...
> 	CONFIG_SND_RTC=$rtcsup
> 	AC_SUBST(CONFIG_SND_RTC)
> 	if test "$CONFIG_SND_RTC" = "1"; then
> 	  AC_DEFINE(CONFIG_SND_RTC)
> 	fi
> 
> Additionally, it's unclear whether the value of CONFIG_SND_RTC should
> be 0/1 or n/m.

they are ruines from the old alsa-driver package.
all should be CONFIG_SND_RTCTIMER and take m/n/y.

fixed now on cvs.
thanks.


Takashi

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: bandwidth@sourceforge.net

Re: CONFIG_SND_RTC and CONFIG_SND_RTCTIMER and CONFIG_RTC, oh my!

[Clemens Ladisch]

Takashi Iwai wrote:
> they are ruines from the old alsa-driver package.
> all should be CONFIG_SND_RTCTIMER and take m/n/y.
> 
> fixed now on cvs.

CONFIG_RTC is still missing. The patch below fakes it.

Additionally, I've modified the initialization of rtcsup.
(but I think it that line wasn't used anyway :)


Index: Makefile.conf.in
===================================================================
RCS file: /cvsroot/alsa/alsa-driver/Makefile.conf.in,v
retrieving revision 1.37
diff -u -r1.37 Makefile.conf.in
--- Makefile.conf.in	14 May 2002 17:55:38 -0000	1.37
+++ Makefile.conf.in	17 May 2002 11:12:56 -0000
@@ -54,6 +54,7 @@
 CONFIG_SND_SEQUENCER_OSS = n
 endif
 CONFIG_SND_RTCTIMER	= @CONFIG_SND_RTCTIMER@
+CONFIG_RTC		= @CONFIG_RTC@
 
 INCLUDE		= -I$(TOPDIR)/include -I$(CONFIG_SND_KERNELDIR)/include
 CFLAGS		= $(MODFLAGS) $(INCLUDE) $(c_opts) -Wall -Wstrict-prototypes -fomit-frame-pointer -pipe
Index: configure.in
===================================================================
RCS file: /cvsroot/alsa/alsa-driver/configure.in,v
retrieving revision 1.106
diff -u -r1.106 configure.in
--- configure.in	14 May 2002 17:55:38 -0000	1.106
+++ configure.in	17 May 2002 11:12:56 -0000
@@ -714,7 +714,7 @@
 
 dnl Check for RTC timer support...
 AC_MSG_CHECKING(for RTC callback support in kernel)
-rtcsup="0"
+rtcsup="n"
 ac_save_CFLAGS="$CFLAGS"
 CFLAGS="$CFLAGS -I$CONFIG_SND_KERNELDIR/include"
 AC_TRY_RUN([
@@ -743,6 +743,8 @@
 CFLAGS=$ac_save_CFLAGS
 CONFIG_SND_RTCTIMER=$rtcsup
 AC_SUBST(CONFIG_SND_RTCTIMER)
+CONFIG_RTC=CONFIG_SND_RTCTIMER
+AC_SUBST(CONFIG_RTC)
 
 dnl Check for which cards to compile driver for...
 ALSA_TOPLEVEL_INIT

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: bandwidth@sourceforge.net

Re: CONFIG_SND_RTC and CONFIG_SND_RTCTIMER and CONFIG_RTC, oh my!

[Takashi Iwai]

At Fri, 17 May 2002 13:21:52 +0200,
Clemens Ladisch wrote:
> 
> Takashi Iwai wrote:
> > they are ruines from the old alsa-driver package.
> > all should be CONFIG_SND_RTCTIMER and take m/n/y.
> > 
> > fixed now on cvs.
> 
> CONFIG_RTC is still missing. The patch below fakes it.
> 
> Additionally, I've modified the initialization of rtcsup.
> (but I think it that line wasn't used anyway :)

thanks.  applied to cvs.


Takashi

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: bandwidth@sourceforge.net