All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Murphy <brian@murphy.dk>
To: linux-mips <linux-mips@oss.sgi.com>
Subject: pcnet32.c bug?
Date: Wed, 29 May 2002 12:46:57 +0200	[thread overview]
Message-ID: <3CF4B1A1.3000607@murphy.dk> (raw)

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

If I don't apply the following patch to pcnet32.c then the network 
connection
on my vr5000 box is extremely jerky. It also seems quite sensible to have a
dma sync operation here.

any comments?

/Brian

[-- Attachment #2: pcnet32.diff --]
[-- Type: text/plain, Size: 518 bytes --]

--- drivers/net/pcnet32.c	19 Mar 2002 16:40:55 -0000	1.1.1.1.2.1.2.6
+++ drivers/net/pcnet32.c	29 May 2002 09:57:33 -0000	1.13.4.2
@@ -1343,6 +1351,10 @@
 		if (!rx_in_place) {
 		    skb_reserve(skb,2); /* 16 byte align */
 		    skb_put(skb,pkt_len);	/* Make room */
+                    pci_dma_sync_single(lp->pci_dev, 
+				    lp->rx_skbuff[entry]->tail, 
+				    pkt_len,
+				    PCI_DMA_FROMDEVICE);
 		    eth_copy_and_sum(skb,
 				     (unsigned char *)(lp->rx_skbuff[entry]->tail),
 				     pkt_len,0);

             reply	other threads:[~2002-05-29 10:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-29 10:46 Brian Murphy [this message]
2002-05-29 14:43 ` pcnet32.c bug? Kevin Paul Herbert
2002-05-30 16:45 ` William Jhun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CF4B1A1.3000607@murphy.dk \
    --to=brian@murphy.dk \
    --cc=linux-mips@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.