All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Jens Axboe <axboe@suse.de>,
	Joe Thornber <joe@fib011235813.fsnet.co.uk>,
	linux-lvm@sistina.com, linux-kernel@vger.kernel.org
Subject: Re: [linux-lvm] LVM2 modifies the buffer_head struct?
Date: Thu Jul  4 00:39:02 2002	[thread overview]
Message-ID: <3D23E0C7.3B30B618@zip.com.au> (raw)
In-Reply-To: 15651.54044.557070.109158@notabene.cse.unsw.edu.au

Neil Brown wrote:
> 
> ...
> We just want ext3/jbd to make sure that it only calls bh2jh on
> an unlocked buffer... is that easy?

It's feasible, but a downright pita.

> Ofcourse this ceases to be an issue in 2.5 because the filesys uses
> pages or buffer_heads and the device driver uses bios.

Well, for 2.4 I'd be inclined to just add the extra field to 
struct buffer_head and be done with it.

Current sizeof(buffer_head) is 96 bytes, and making that 100 would
be a nuisance, but its quite easy to shrink the buffer_head a
bit (replace b_inode with BH_inode, say...).

-

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@zip.com.au>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Jens Axboe <axboe@suse.de>,
	Joe Thornber <joe@fib011235813.fsnet.co.uk>,
	linux-lvm@sistina.com, linux-kernel@vger.kernel.org
Subject: Re: [linux-lvm] LVM2 modifies the buffer_head struct?
Date: Wed, 03 Jul 2002 22:44:39 -0700	[thread overview]
Message-ID: <3D23E0C7.3B30B618@zip.com.au> (raw)
In-Reply-To: 15651.54044.557070.109158@notabene.cse.unsw.edu.au

Neil Brown wrote:
> 
> ...
> We just want ext3/jbd to make sure that it only calls bh2jh on
> an unlocked buffer... is that easy?

It's feasible, but a downright pita.

> Ofcourse this ceases to be an issue in 2.5 because the filesys uses
> pages or buffer_heads and the device driver uses bios.

Well, for 2.4 I'd be inclined to just add the extra field to 
struct buffer_head and be done with it.

Current sizeof(buffer_head) is 96 bytes, and making that 100 would
be a nuisance, but its quite easy to shrink the buffer_head a
bit (replace b_inode with BH_inode, say...).

-

  reply	other threads:[~2002-07-04  0:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-02  8:41 [linux-lvm] LVM2 modifies the buffer_head struct? Tom Walcott
2002-07-02  9:17 ` Joe Thornber
2002-07-02 14:17   ` Joe Thornber
2002-07-03  5:09   ` Jens Axboe
2002-07-03 10:08     ` Jens Axboe
2002-07-03  5:23     ` Andrew Morton
2002-07-03 10:28       ` Andrew Morton
2002-07-03  7:01     ` Joe Thornber
2002-07-03 12:01       ` Joe Thornber
2002-07-03  7:10       ` Jens Axboe
2002-07-03 12:10         ` Jens Axboe
2002-07-03 23:44         ` Neil Brown
2002-07-04  4:46           ` Neil Brown
2002-07-04  0:39           ` Andrew Morton [this message]
2002-07-04  5:44             ` Andrew Morton
2002-07-04  2:46           ` Joe Thornber
2002-07-04  7:45             ` Joe Thornber
2002-07-04  2:58           ` Jens Axboe
2002-07-04  7:58             ` Jens Axboe
2002-07-04  3:34             ` Andrew Morton
2002-07-04  8:40               ` Andrew Morton
2002-07-04  3:40               ` Jens Axboe
2002-07-04  8:39                 ` Jens Axboe
2002-07-04  3:58                 ` Joe Thornber
2002-07-04  8:57                   ` Joe Thornber
2002-07-04  4:00                   ` Jens Axboe
2002-07-04  9:00                     ` Jens Axboe
2002-07-04  4:38                 ` Andrew Morton
2002-07-04  9:44                   ` Andrew Morton
2002-07-07 14:52                   ` Joe Thornber
2002-07-07 20:51                     ` Joe Thornber
  -- strict thread matches above, loose matches on Subject: below --
2002-07-05  0:21 Mark Peloquin
2002-07-05 15:23 Mark Peloquin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D23E0C7.3B30B618@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=axboe@suse.de \
    --cc=joe@fib011235813.fsnet.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-lvm@sistina.com \
    --cc=neilb@cse.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.