From: Andrew Morton <akpm@digeo.com>
To: Zach Brown <zab@zabbo.net>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: suspect list_empty( {NULL, NULL} )
Date: Sat, 28 Sep 2002 18:31:57 -0700 [thread overview]
Message-ID: <3D96580D.A0F803BC@digeo.com> (raw)
In-Reply-To: 20020928205836.C13817@bitchcake.off.net
Zach Brown wrote:
>
> A cute list_head debugging patch seems to have found strange list_entry
> use in vmscan.c in stock 2.5.39.
>
> page_mapping_inuse:
>
> if (!list_empty(&mapping->i_mmap) || !list_empty(&mapping->i_mmap_shared))
>
> ...
> (gdb) print *mapping
> $22 = {host = 0xc03b6e00
That's swapper_space.
--- 2.5.39/mm/swap_state.c~swapper_space-state Sat Sep 28 18:30:45 2002
+++ 2.5.39-akpm/mm/swap_state.c Sat Sep 28 18:31:26 2002
@@ -43,6 +43,8 @@ struct address_space swapper_space = {
.a_ops = &swap_aops,
.backing_dev_info = &swap_backing_dev_info,
.i_shared_lock = SPIN_LOCK_UNLOCKED,
+ .i_mmap = LIST_HEAD_INIT(swapper_space.i_mmap),
+ .i_mmap_shared = LIST_HEAD_INIT(swapper_space.i_mmap_shared),
.private_lock = SPIN_LOCK_UNLOCKED,
.private_list = LIST_HEAD_INIT(swapper_space.private_list),
};
.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: Zach Brown <zab@zabbo.net>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: suspect list_empty( {NULL, NULL} )
Date: Sat, 28 Sep 2002 18:31:57 -0700 [thread overview]
Message-ID: <3D96580D.A0F803BC@digeo.com> (raw)
In-Reply-To: 20020928205836.C13817@bitchcake.off.net
Zach Brown wrote:
>
> A cute list_head debugging patch seems to have found strange list_entry
> use in vmscan.c in stock 2.5.39.
>
> page_mapping_inuse:
>
> if (!list_empty(&mapping->i_mmap) || !list_empty(&mapping->i_mmap_shared))
>
> ...
> (gdb) print *mapping
> $22 = {host = 0xc03b6e00
That's swapper_space.
--- 2.5.39/mm/swap_state.c~swapper_space-state Sat Sep 28 18:30:45 2002
+++ 2.5.39-akpm/mm/swap_state.c Sat Sep 28 18:31:26 2002
@@ -43,6 +43,8 @@ struct address_space swapper_space = {
.a_ops = &swap_aops,
.backing_dev_info = &swap_backing_dev_info,
.i_shared_lock = SPIN_LOCK_UNLOCKED,
+ .i_mmap = LIST_HEAD_INIT(swapper_space.i_mmap),
+ .i_mmap_shared = LIST_HEAD_INIT(swapper_space.i_mmap_shared),
.private_lock = SPIN_LOCK_UNLOCKED,
.private_list = LIST_HEAD_INIT(swapper_space.private_list),
};
.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-09-29 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 0:58 suspect list_empty( {NULL, NULL} ) Zach Brown
2002-09-29 0:58 ` Zach Brown
2002-09-29 1:31 ` Andrew Morton [this message]
2002-09-29 1:31 ` Andrew Morton
2002-09-29 2:11 ` Zach Brown
2002-09-29 2:11 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D96580D.A0F803BC@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.