From: Andrew Morton <akpm@digeo.com>
To: Zach Brown <zab@zabbo.net>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH] vma->shared list_head initializations
Date: Sat, 28 Sep 2002 21:49:22 -0700 [thread overview]
Message-ID: <3D968652.28AD6766@digeo.com> (raw)
In-Reply-To: 20020928234930.F13817@bitchcake.off.net
Zach Brown wrote:
>
> more list_head debugging carnage.
>
yup
> --- linux-2.5.39/fs/exec.c.fmuta Sat Sep 28 19:50:20 2002
> +++ linux-2.5.39/fs/exec.c Sat Sep 28 19:51:08 2002
> @@ -400,6 +400,7 @@
> mpnt->vm_ops = NULL;
> mpnt->vm_pgoff = 0;
> mpnt->vm_file = NULL;
> + INIT_LIST_HEAD(&mpnt->shared);
> mpnt->vm_private_data = (void *) 0;
> insert_vm_struct(mm, mpnt);
> mm->total_vm = (mpnt->vm_end - mpnt->vm_start) >> PAGE_SHIFT;
Fair enough, short-term. But what your patch is really saying
is "this code stinks".
We need to lose all those open-coded accesses to vm_area_cachep,
give that cache a constructor and possibly write some helper
functions. To lose all this fragile "did I remember to
initialise everything and has anyone added any more fields
since I wrote that code" gunk.
<looks hopefully at Christoph>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: Zach Brown <zab@zabbo.net>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH] vma->shared list_head initializations
Date: Sat, 28 Sep 2002 21:49:22 -0700 [thread overview]
Message-ID: <3D968652.28AD6766@digeo.com> (raw)
In-Reply-To: 20020928234930.F13817@bitchcake.off.net
Zach Brown wrote:
>
> more list_head debugging carnage.
>
yup
> --- linux-2.5.39/fs/exec.c.fmuta Sat Sep 28 19:50:20 2002
> +++ linux-2.5.39/fs/exec.c Sat Sep 28 19:51:08 2002
> @@ -400,6 +400,7 @@
> mpnt->vm_ops = NULL;
> mpnt->vm_pgoff = 0;
> mpnt->vm_file = NULL;
> + INIT_LIST_HEAD(&mpnt->shared);
> mpnt->vm_private_data = (void *) 0;
> insert_vm_struct(mm, mpnt);
> mm->total_vm = (mpnt->vm_end - mpnt->vm_start) >> PAGE_SHIFT;
Fair enough, short-term. But what your patch is really saying
is "this code stinks".
We need to lose all those open-coded accesses to vm_area_cachep,
give that cache a constructor and possibly write some helper
functions. To lose all this fragile "did I remember to
initialise everything and has anyone added any more fields
since I wrote that code" gunk.
<looks hopefully at Christoph>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-09-29 4:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 3:49 [PATCH] vma->shared list_head initializations Zach Brown
2002-09-29 3:49 ` Zach Brown
2002-09-29 4:49 ` Andrew Morton [this message]
2002-09-29 4:49 ` Andrew Morton
2002-09-29 13:31 ` [PATCH] add callback back to slab pruning Ed Tomlinson
2002-09-29 15:47 ` Andrew Morton
2002-09-29 18:38 ` Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D968652.28AD6766@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.