All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	Marcelo Tosatti <marcelo@conectiva.com.br>,
	Chuck Lever <cel@netapp.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux FSdevel <linux-fsdevel@vger.kernel.org>,
	NFS maillist <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] 2.4.20 Direct IO patch for NFS. (Note: a trivial API change...)
Date: Mon, 30 Sep 2002 12:04:44 -0700	[thread overview]
Message-ID: <3D98A04C.2FE206EE@digeo.com> (raw)
In-Reply-To: 20020930194227.A22095@infradead.org

Christoph Hellwig wrote:
> 
> On Mon, Sep 30, 2002 at 08:34:04PM +0200, Trond Myklebust wrote:
> >
> > Hi Marcelo,
> >
> >   The following patch implements direct I/O for NFS as a compilation option.
> > It does not in any way touch the standard NFS read/write code, however it
> > does change the interface for generic direct I/O: Instead of taking a
> > 'struct inode' argument, we need to take the full 'struct file' in order
> > to be able to pass the RPC credential information down to the NFS layer.
> 
> I don't think changing the filesystem entry points during 2.4 is an option.
> 

It's a very small change; I wouldn't be very fussed about it personally.

To be source-compatible with out-of-kernel filesystems you could add
a new a_op and do

	if (mapping->direct_IO_which_uses_a_filp)
		use that
	else
		use mapping->direct_IO

but ick.


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	Marcelo Tosatti <marcelo@conectiva.com.br>,
	Chuck Lever <cel@netapp.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux FSdevel <linux-fsdevel@vger.kernel.org>,
	NFS maillist <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] 2.4.20 Direct IO patch for NFS. (Note: a trivial API  change...)
Date: Mon, 30 Sep 2002 12:04:44 -0700	[thread overview]
Message-ID: <3D98A04C.2FE206EE@digeo.com> (raw)
In-Reply-To: 20020930194227.A22095@infradead.org

Christoph Hellwig wrote:
> 
> On Mon, Sep 30, 2002 at 08:34:04PM +0200, Trond Myklebust wrote:
> >
> > Hi Marcelo,
> >
> >   The following patch implements direct I/O for NFS as a compilation option.
> > It does not in any way touch the standard NFS read/write code, however it
> > does change the interface for generic direct I/O: Instead of taking a
> > 'struct inode' argument, we need to take the full 'struct file' in order
> > to be able to pass the RPC credential information down to the NFS layer.
> 
> I don't think changing the filesystem entry points during 2.4 is an option.
> 

It's a very small change; I wouldn't be very fussed about it personally.

To be source-compatible with out-of-kernel filesystems you could add
a new a_op and do

	if (mapping->direct_IO_which_uses_a_filp)
		use that
	else
		use mapping->direct_IO

but ick.

  parent reply	other threads:[~2002-09-30 19:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-30 18:34 [PATCH] 2.4.20 Direct IO patch for NFS. (Note: a trivial API change...) Trond Myklebust
2002-09-30 18:42 ` Christoph Hellwig
2002-09-30 18:46   ` Trond Myklebust
2002-09-30 18:46     ` Trond Myklebust
2002-09-30 19:04   ` Andrew Morton [this message]
2002-09-30 19:04     ` Andrew Morton
2002-09-30 19:18   ` Alan Cox
2002-09-30 18:52 ` Matthew Wilcox
2002-09-30 18:57   ` Trond Myklebust
2002-09-30 18:57     ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D98A04C.2FE206EE@digeo.com \
    --to=akpm@digeo.com \
    --cc=cel@netapp.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.