From: Andrew Morton <akpm@digeo.com>
To: Thomas Molina <tmolina@cox.net>
Cc: Steve Parker <steve.parker@netops.co.uk>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.41 still not testable by end users
Date: Thu, 17 Oct 2002 15:39:50 -0700 [thread overview]
Message-ID: <3DAF3C36.2065CFD1@digeo.com> (raw)
In-Reply-To: Pine.LNX.4.44.0210171717550.18123-100000@dad.molina
Thomas Molina wrote:
>
> ...
> > > Oct 16 21:40:59 declan kernel: [__might_sleep+84/96]
> > > ...
> > > Oct 16 21:41:00 declan kernel: [init_irq+637/820] init_irq+0x27d/0x334
> > >
> >
> > One day. Before we all die. Please.
>
> I had that as fixed in my problem list. It should have been integrated by
> 2.5.42, certainly 2.5.43. I'm not seeing any additional reports since
> then.
Oh. We still have:
if (request_irq(hwif->irq,&ide_intr,sa,hwif->name,hwgroup)) {
if (!match)
kfree(hwgroup);
spin_unlock_irqrestore(&ide_lock, flags);
request_irq() was changed to use GFP_ATOMIC, so it's "fixed".
But only for i386.
request_irq() inside spinlock is a *very* common bug. Moreso
as people move cli()-using code across to use spinlocks.
And we've just lost our ability to detect this bug.
request_irq() needs to take the allocation mode as an argument.
Should always have. Sigh. I'll fix it up sometime.
next prev parent reply other threads:[~2002-10-17 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 2:35 2.5.41 still not testable by end users Steve Parker
2002-10-17 2:55 ` Andrew Morton
2002-10-17 22:23 ` Thomas Molina
2002-10-17 22:39 ` Andrew Morton [this message]
2002-10-18 2:48 ` Andi Kleen
2002-10-18 3:35 ` Andrew Morton
2002-10-21 10:59 ` Alan Cox
2002-10-18 8:43 ` Arjan van de Ven
2002-10-21 10:56 ` Alan Cox
2002-10-17 23:15 ` Steve Parker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DAF3C36.2065CFD1@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.parker@netops.co.uk \
--cc=tmolina@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.