From: Andrew Morton <akpm@digeo.com>
To: Andi Kleen <ak@muc.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.41 still not testable by end users
Date: Thu, 17 Oct 2002 20:35:52 -0700 [thread overview]
Message-ID: <3DAF8198.A66E0C82@digeo.com> (raw)
In-Reply-To: m3smz4o415.fsf@averell.firstfloor.org
Andi Kleen wrote:
>
> Andrew Morton <akpm@digeo.com> writes:
> >
> > request_irq() needs to take the allocation mode as an argument.
> > Should always have. Sigh. I'll fix it up sometime.
>
> If you change it I would change it to let the caller pass it in. Then
> it's explicit and most drivers can just slab it somewhere in their
> private structures without any allocation.
>
Well that would require that the drivers become aware of struct irqaction,
and make assumptions about how the particular arch handles interrupts.
But it's a bit academic. ia32's request_irq() calls proc_mkdir() and
create_proc_entry(). So there's no point in feeding gfp_flags down
into request_irq or whatever. We need to fix IDE still.
next prev parent reply other threads:[~2002-10-18 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 2:35 2.5.41 still not testable by end users Steve Parker
2002-10-17 2:55 ` Andrew Morton
2002-10-17 22:23 ` Thomas Molina
2002-10-17 22:39 ` Andrew Morton
2002-10-18 2:48 ` Andi Kleen
2002-10-18 3:35 ` Andrew Morton [this message]
2002-10-21 10:59 ` Alan Cox
2002-10-18 8:43 ` Arjan van de Ven
2002-10-21 10:56 ` Alan Cox
2002-10-17 23:15 ` Steve Parker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DAF8198.A66E0C82@digeo.com \
--to=akpm@digeo.com \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.