All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Ed Tomlinson <tomlins@cam.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Chris Mason <mason@suse.com>
Subject: Re: 2.5.46-mm2 - oops
Date: Sun, 10 Nov 2002 10:52:19 -0800	[thread overview]
Message-ID: <3DCEAAE3.C6EE63EF@digeo.com> (raw)
In-Reply-To: 200211101309.21447.tomlins@cam.org

Ed Tomlinson wrote:
> 
> On November 9, 2002 10:59 pm, Andrew Morton wrote:
> 
> > Of note in -mm2 is a patch from Chris Mason which teaches reiserfs to
> > use the mpage code for reads - it should show a nice reduction in CPU
> > load under reiserfs reads.
> 
> Booting into mm2 I get:
> 
> ...
> Unable to handle kernel NULL pointer dereference at virtual address 00000004
> 
> ...
> EIP is at mpage_readpages+0x47/0x140

whoops.  The ->readpages API was changed...

--- 25/fs/reiserfs/inode.c~reiserfs-readpages-fix	Sun Nov 10 10:44:28 2002
+++ 25-akpm/fs/reiserfs/inode.c	Sun Nov 10 10:44:39 2002
@@ -2081,7 +2081,7 @@ static int reiserfs_readpage (struct fil
 }
 
 static int
-reiserfs_readpages(struct address_space *mapping,
+reiserfs_readpages(struct file *file, struct address_space *mapping,
                struct list_head *pages, unsigned nr_pages)
 {
     return mpage_readpages(mapping, pages, nr_pages, reiserfs_get_block);

_

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: Ed Tomlinson <tomlins@cam.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Chris Mason <mason@suse.com>
Subject: Re: 2.5.46-mm2 - oops
Date: Sun, 10 Nov 2002 10:52:19 -0800	[thread overview]
Message-ID: <3DCEAAE3.C6EE63EF@digeo.com> (raw)
In-Reply-To: 200211101309.21447.tomlins@cam.org

Ed Tomlinson wrote:
> 
> On November 9, 2002 10:59 pm, Andrew Morton wrote:
> 
> > Of note in -mm2 is a patch from Chris Mason which teaches reiserfs to
> > use the mpage code for reads - it should show a nice reduction in CPU
> > load under reiserfs reads.
> 
> Booting into mm2 I get:
> 
> ...
> Unable to handle kernel NULL pointer dereference at virtual address 00000004
> 
> ...
> EIP is at mpage_readpages+0x47/0x140

whoops.  The ->readpages API was changed...

--- 25/fs/reiserfs/inode.c~reiserfs-readpages-fix	Sun Nov 10 10:44:28 2002
+++ 25-akpm/fs/reiserfs/inode.c	Sun Nov 10 10:44:39 2002
@@ -2081,7 +2081,7 @@ static int reiserfs_readpage (struct fil
 }
 
 static int
-reiserfs_readpages(struct address_space *mapping,
+reiserfs_readpages(struct file *file, struct address_space *mapping,
                struct list_head *pages, unsigned nr_pages)
 {
     return mpage_readpages(mapping, pages, nr_pages, reiserfs_get_block);

_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

  reply	other threads:[~2002-11-10 18:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-10  3:59 2.5.46-mm2 Andrew Morton
2002-11-10  3:59 ` 2.5.46-mm2 Andrew Morton
2002-11-10 14:32 ` 2.5.46-mm2 Jens Axboe
2002-11-10 14:52   ` 2.5.46-mm2 William Lee Irwin III
2002-11-10 14:52     ` 2.5.46-mm2 William Lee Irwin III
2002-11-10 14:57     ` 2.5.46-mm2 Jens Axboe
2002-11-10 14:57       ` 2.5.46-mm2 Jens Axboe
2002-11-10 15:06       ` 2.5.46-mm2 William Lee Irwin III
2002-11-10 15:06         ` 2.5.46-mm2 William Lee Irwin III
2002-11-10 15:58         ` 2.5.46-mm2 Jens Axboe
2002-11-10 15:58           ` 2.5.46-mm2 Jens Axboe
2002-11-10 19:39           ` 2.5.46-mm2 Andrew Morton
2002-11-10 19:39             ` 2.5.46-mm2 Andrew Morton
2002-11-11  1:18             ` 2.5.46-mm2 William Lee Irwin III
2002-11-11  1:18               ` 2.5.46-mm2 William Lee Irwin III
2002-11-11  7:04             ` 2.5.46-mm2 Jens Axboe
2002-11-11  7:04               ` 2.5.46-mm2 Jens Axboe
2002-11-11  7:41               ` 2.5.46-mm2 William Lee Irwin III
2002-11-11  7:41                 ` 2.5.46-mm2 William Lee Irwin III
2002-11-10 16:58         ` 2.5.46-mm2 Andrew Morton
2002-11-10 16:58           ` 2.5.46-mm2 Andrew Morton
2002-11-10 17:11           ` 2.5.46-mm2 William Lee Irwin III
2002-11-10 17:11             ` 2.5.46-mm2 William Lee Irwin III
2002-11-10 23:10             ` 2.5.46-mm2 Toon van der Pas
2002-11-10 18:14 ` 2.5.46-mm2 - oops Ed Tomlinson
2002-11-10 18:14   ` Ed Tomlinson
2002-11-10 18:52   ` Andrew Morton [this message]
2002-11-10 18:52     ` Andrew Morton
2002-11-10 19:17     ` Ed Tomlinson
2002-11-10 19:17       ` Ed Tomlinson
2002-11-11  0:44     ` Denis Vlasenko
2002-11-11  0:44       ` Denis Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DCEAAE3.C6EE63EF@digeo.com \
    --to=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mason@suse.com \
    --cc=tomlins@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.