From: Andrew Morton <akpm@digeo.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Mark Hazell <nutts@penguinmail.com>,
adilger@clusterfs.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch/2.4] ll_rw_blk stomping on bh state [Re: kernel BUG at journal.c:1732! (2.4.19)]
Date: Tue, 12 Nov 2002 09:57:05 -0800 [thread overview]
Message-ID: <3DD140F1.F4AED387@digeo.com> (raw)
In-Reply-To: 20021112150711.F2837@redhat.com
"Stephen C. Tweedie" wrote:
>
> if (maxsector < count || maxsector - count < sector) {
> /* Yecch */
> bh->b_state &= (1 << BH_Lock) | (1 << BH_Mapped);
>
> ...
>
> Folks, just which buffer flags do we want to preserve in this case?
>
Why do we want to clear any flags in there at all? To prevent
a storm of error messages from a buffer which has a silly block
number?
If so, how about setting a new state bit which causes subsequent
IO attempts to silently drop the IO on the floor?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Mark Hazell <nutts@penguinmail.com>,
adilger@clusterfs.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch/2.4] ll_rw_blk stomping on bh state [Re: kernel BUG at journal.c:1732! (2.4.19)]
Date: Tue, 12 Nov 2002 09:57:05 -0800 [thread overview]
Message-ID: <3DD140F1.F4AED387@digeo.com> (raw)
In-Reply-To: 20021112150711.F2837@redhat.com
"Stephen C. Tweedie" wrote:
>
> if (maxsector < count || maxsector - count < sector) {
> /* Yecch */
> bh->b_state &= (1 << BH_Lock) | (1 << BH_Mapped);
>
> ...
>
> Folks, just which buffer flags do we want to preserve in this case?
>
Why do we want to clear any flags in there at all? To prevent
a storm of error messages from a buffer which has a silly block
number?
If so, how about setting a new state bit which causes subsequent
IO attempts to silently drop the IO on the floor?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-11-12 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20021028111357.78197071.nutts@penguinmail.com>
2002-11-12 15:07 ` [patch/2.4] ll_rw_blk stomping on bh state [Re: kernel BUG at journal.c:1732! (2.4.19)] Stephen C. Tweedie
2002-11-12 17:57 ` Andrew Morton [this message]
2002-11-12 17:57 ` Andrew Morton
2002-11-12 18:53 ` Stephen C. Tweedie
2002-11-12 18:53 ` Stephen C. Tweedie
2002-11-15 17:38 ` Stephen C. Tweedie
2002-11-15 17:38 ` Stephen C. Tweedie
2002-11-15 18:05 ` Andrew Morton
2002-11-15 18:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD140F1.F4AED387@digeo.com \
--to=akpm@digeo.com \
--cc=adilger@clusterfs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nutts@penguinmail.com \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.