[2.5] pcnet_cs, uninitialized timer when removing

[2.5] pcnet_cs, uninitialized timer when removing

[Jochen Hein]

When I remove the card I get:

Linux version 2.5.47 (root@gswi1164) (gcc version 2.95.4 20011002 (Debian prerelease)) #1 Mon Nov 11 19:55:09 CET 2002
[...]
Uninitialised timer!
This is just a warning.  Your computer is OK
function=0xc6ab9e64, data=0xc4d1a560
Call Trace: [<c0121660>]  [<c6ab9e64>]  [<c01218c0>]  [<c6ab9f81>]  [<c6aa2326>]  [<c6aaafc0>]  [<c6aa2353>]  [<c6aa23d6>]  [<c6aaaf80>]  [<c6aa9e2e>]  [<c6aaaf80>]  [<c01271c1>]  [<c6aaaf80>]  [<c0126fd8>]  [<c6aaaf80>]  [<c6aa9df0>]  [<c0117350>]  [<c0117350>]  [<c0106e79>] 

ksymoops 2.4.6 on i686 2.5.47.  Options used
     -V (default)
     -k /proc/ksyms (default)
     -l /proc/modules (default)
     -o /lib/modules/2.5.47/ (default)
     -m /boot/System.map-2.5.47 (default)

Warning: You did not tell me where to find symbol information.  I will
assume that the log matches the kernel and modules that are running
right now and I'll use the default options above for symbol resolution.
If the current kernel and/or modules do not match the log, you can get
more accurate output by telling me the kernel version and where to find
map, modules, ksyms etc.  ksymoops -h explains the options.

cs: IO port probe 0x0c00-0x0cff: clean.
cs: IO port probe 0x0800-0x08ff: clean.
cs: IO port probe 0x0100-0x04ff: clean.
cs: IO port probe 0x0a00-0x0aff: clean.
cs: memory probe 0xa0000000-0xa0ffffff: clean.
Call Trace: [<c0121660>]  [<c6ab9e64>]  [<c01218c0>]  [<c6ab9f81>]  [<c6aa2326>]  [<c6aaafc0>]  [<c6aa2353>]  [<c6aa23d6>]  [<c6aaaf80>]  [<c6aa9e2e>]  [<c6aaaf80>]  [<c01271c1>]  [<c6aaaf80>]  [<c0126fd8>]  [<c6aaaf80>]  [<c6aa9df0>]  [<c0117350>]  [<c0117350>]  [<c0106e79>] 

Processed with ksymoops:

Warning (Oops_read): Code line not seen, dumping what data is available


Trace; c0121660 <check_timer_failed+40/4c>
Trace; c6ab9e64 <[pcnet_cs]pcnet_release+0/74>
Trace; c01218c0 <mod_timer+34/1f0>
Trace; c6ab9f81 <[pcnet_cs]pcnet_event+a9/1a0>
Trace; c6aa2326 <[pcmcia_core]send_event+32/44>
Trace; c6aaafc0 <[yenta_socket].bss.start+40/5bf>
Trace; c6aa2353 <[pcmcia_core]do_shutdown+1b/64>
Trace; c6aa23d6 <[pcmcia_core]parse_events+3a/d8>
Trace; c6aaaf80 <[yenta_socket]pci_socket_array+0/0>
Trace; c6aa9e2e <[yenta_socket]yenta_bh+3e/44>
Trace; c6aaaf80 <[yenta_socket]pci_socket_array+0/0>
Trace; c01271c1 <worker_thread+1e9/2cc>
Trace; c6aaaf80 <[yenta_socket]pci_socket_array+0/0>
Trace; c0126fd8 <worker_thread+0/2cc>
Trace; c6aaaf80 <[yenta_socket]pci_socket_array+0/0>
Trace; c6aa9df0 <[yenta_socket]yenta_bh+0/44>
Trace; c0117350 <default_wake_function+0/34>
Trace; c0117350 <default_wake_function+0/34>
Trace; c0106e79 <kernel_thread_helper+5/c>


2 warnings issued.  Results may not be reliable.

Jochen

-- 
Wenn Du nicht weißt was Du tust, tu's mit Eleganz.

Re: [2.5] pcnet_cs, uninitialized timer when removing

[Andrew Morton]

Jochen Hein wrote:
> 
> When I remove the card I get:
> 
> ...
> 
> Trace; c0121660 <check_timer_failed+40/4c>
> Trace; c6ab9e64 <[pcnet_cs]pcnet_release+0/74>

Thanks, I'll fix that up.


--- 25/drivers/net/pcmcia/pcnet_cs.c~timer-mopup	Fri Nov 22 10:16:49 2002
+++ 25-akpm/drivers/net/pcmcia/pcnet_cs.c	Fri Nov 22 10:17:09 2002
@@ -300,7 +300,8 @@ static dev_link_t *pcnet_attach(void)
     memset(info, 0, sizeof(*info));
     link = &info->link; dev = &info->dev;
     link->priv = info;
-    
+
+    init_timer(&link->release);
     link->release.function = &pcnet_release;
     link->release.data = (u_long)link;
     link->irq.Attributes = IRQ_TYPE_EXCLUSIVE;

_