* [patch] IDE fix for current -bk
@ 2002-11-26 5:30 Andrew Morton
2002-11-26 15:05 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2002-11-26 5:30 UTC (permalink / raw)
To: Linus Torvalds, Alan Cox, lkml
do_ide_setup_pci_device() is returning an uninitialised
ata_index_t causing an oops at bootup.
--- 25/drivers/ide/setup-pci.c~ide-fix Mon Nov 25 21:24:42 2002
+++ 25-akpm/drivers/ide/setup-pci.c Mon Nov 25 21:25:11 2002
@@ -693,7 +693,7 @@ static ata_index_t do_ide_setup_pci_devi
int autodma = 0;
int pciirq = 0;
int tried_config = 0;
- ata_index_t index;
+ ata_index_t index = { .b = { .low = 0xff, .high = 0xff } };
if((autodma = ide_setup_pci_controller(dev, d, noisy, &tried_config)) < 0)
return index;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] IDE fix for current -bk
2002-11-26 5:30 [patch] IDE fix for current -bk Andrew Morton
@ 2002-11-26 15:05 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2002-11-26 15:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linus Torvalds, lkml
On Tue, 2002-11-26 at 05:30, Andrew Morton wrote:
> do_ide_setup_pci_device() is returning an uninitialised
> ata_index_t causing an oops at bootup.
Its initialized by ide_pci_setup_ports
index->all = 0xF0F0
but yes you are right - the error path can return it uninitialized.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-11-26 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-26 5:30 [patch] IDE fix for current -bk Andrew Morton
2002-11-26 15:05 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.