Re: [Bluez-devel] BlueZ HCIDump 1.5 has been released

Re: [Bluez-devel] BlueZ HCIDump 1.5 has been released

[Maksim Yevmenkin]

Hello Max,

[...]

> >or I'm missing something.
> No you're not. HCIDump code does need some audit.

ok :)

> >Also I have a HUGE favor to ask :) Would it be too hard to not
> >use *any* Linux specific stuff? Here I'm talking about things
> >like
> >
> >1) data types: __u8, __u16 etc. Would it be possible to
> >   use standard <sys/types.h>
> Yeah. We converted all headers and stuff but forgot about hcidump.
> btw We use <stdint.h> instead of <sys/types.h> i.e. uint32_t, etc.
>
> >2) Any stuff from <asm/*.h> including "get_unaligned()"
> Sure.
> 
> >3) Man page is very strange. Mdoc macros are used seems to
> >   be Linux (new mdoc?) specific.
> No idea what you're talking about :). Looks perfectly ok to me.

well, how about the following

1) Some macros have wrong capitalization. For example: .SH and .PP
   i think it should be .Sh and .Pp

2) Use of .TH macro with hardwired "Linux System Administration".
   Instead i would suggest to use something like

   .Dd November, 12 2002
   .Dt HCIDUMP 1
   .Os

3) Use of .B macro where .Nm should be used.

4) SYNOPSIS section probably should use .Op Fl opt Ar arg macro.

5) All lists and list items probably should use .Bl, .It and
   .El macros.

6) AUTHORS section probably should use .An Name Aq e-mail macro.
 
7) man page has name hcidump.8 (i.e. section 8) but the page itself
   says its section 1.

> >It would make porting so much easier. Should I made the patches
> >and submit them ?
> Yes, by all means.

ok.

thanks,
max


-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel