[PATCH]: Fix oops with pending/23_REJECT-headroom-tcprst.patch

[PATCH]: Fix oops with pending/23_REJECT-headroom-tcprst.patch

[Patrick McHardy]

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]

Hi Harald,
this patch fixes an oops with 23-REJECT-headroom-tcprst.patch (nskb is 
used before copy).

Regards,
Patrick


[-- Attachment #2: 23_REJECT-headroom-tcprst-fix.diff --]
[-- Type: text/plain, Size: 982 bytes --]

? conntrack-fragments
? linux-2.4.20-clean
? linux-2.4.20-nf
? linux-2.4.20.tar.bz2
? netfilter-nobssinit.diff
Index: patch-o-matic/pending/23_REJECT-headroom-tcprst.patch
===================================================================
RCS file: /cvspublic/netfilter/patch-o-matic/pending/23_REJECT-headroom-tcprst.patch,v
retrieving revision 1.2
diff -u -r1.2 23_REJECT-headroom-tcprst.patch
--- patch-o-matic/pending/23_REJECT-headroom-tcprst.patch	5 Mar 2003 07:51:47 -0000	1.2
+++ patch-o-matic/pending/23_REJECT-headroom-tcprst.patch	11 Mar 2003 02:54:35 -0000
@@ -14,9 +14,9 @@
  		return;
  
 +	/* Routing: if not headed for us, route won't like source */
-+	if (ip_route_output(&rt, nskb->nh.iph->daddr,
-+			    local ? nskb->nh.iph->saddr : 0,
-+			    RT_TOS(nskb->nh.iph->tos) | RTO_CONN,
++	if (ip_route_output(&rt, oldskb->nh.iph->daddr,
++			    local ? oldskb->nh.iph->saddr : 0,
++			    RT_TOS(oldskb->nh.iph->tos) | RTO_CONN,
 +			    0) != 0)
 +		return;
 +

Re: [PATCH]: Fix oops with pending/23_REJECT-headroom-tcprst.patch

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

On Tue, Mar 11, 2003 at 04:00:33AM +0100, Patrick McHardy wrote:
> Hi Harald,
> this patch fixes an oops with 23-REJECT-headroom-tcprst.patch (nskb is 
> used before copy).

thanks, stupid mistake while porting the fix from 2.5.x -> 2.4.x

applied (and bug 22 updated)

> Regards,
> Patrick
-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]