[PATCH] Dead code elimination in ip_conntrack_core.c

[PATCH] Dead code elimination in ip_conntrack_core.c

[Stephane Ouellette]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

List members,

    the following cosmetic patch removes dead code in 
ip_conntrack_init() if CONFIG_SYSCTL is not defined.
The patch applies against a plain 2.4.21-pre5-ac3 kernel.

Regards,

Stephane Ouellette


[-- Attachment #2: ip_conntrack_core.c.patch --]
[-- Type: text/plain, Size: 439 bytes --]

--- linux-2.4.21-pre5-ac3/net/ipv4/netfilter/ip_conntrack_core.c	Sat Mar 15 12:16:55 2003
+++ linux-2.4.21-pre5-ac3-fixed/net/ipv4/netfilter/ip_conntrack_core.c	Sat Mar 15 12:23:34 2003
@@ -1478,8 +1478,10 @@
 	ip_ct_attach = ip_conntrack_attach;
 	return ret;
 
+#ifdef CONFIG_SYSCTL
 err_free_ct_cachep:
 	kmem_cache_destroy(ip_conntrack_cachep);
+#endif /*CONFIG_SYSCTL*/
 err_free_hash:
 	vfree(ip_conntrack_hash);
 err_unreg_sockopt:

Re: [PATCH] Dead code elimination in ip_conntrack_core.c

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

On Sat, Mar 15, 2003 at 12:30:04PM -0500, Stephane Ouellette wrote:
> List members,
> 
>    the following cosmetic patch removes dead code in 
> ip_conntrack_init() if CONFIG_SYSCTL is not defined.
> The patch applies against a plain 2.4.21-pre5-ac3 kernel.

thanks, I'm including your patch into 'pending'

> Regards,
> Stephane Ouellette
-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]